Skip to content

Update contributor-guide.adoc #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update contributor-guide.adoc #96

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f83d923
Update contributor-guide.adoc
julienlim Jan 25, 2018
a986c30
Merge branch 'master' into julienlim-patch-1
r0h4n Feb 17, 2018
abf88cc
Merge branch 'master' into julienlim-patch-1
r0h4n Mar 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contributor-guide.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@

== Tendrl PR review tips

- [*] Check PR for CPU impact (long running loops, blocking calls etc)
- [*] Check PR for CPU and memory impact (long running loops, blocking calls etc)
- [*] Check for IO (disk and network, etcd/db) impact (local files, network calls to etcd or others, etcd performance)
- [*] Check PR for application response time impact
- [*] Check for Platform, SDS, Integrations and Tendrl security impact
- [*] Check Scalability (does the PR work in a multi node Tendrl deployment and sds cluster)
- [*] Check readability and maintainability of the code
Expand Down