-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 全局配置规范性修正 #1215
Open
zouxingyuks
wants to merge
3
commits into
TencentBlueKing:v1.7.x
Choose a base branch
from
zouxingyuks:feature/global-config-v2
base: v1.7.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: 全局配置规范性修正 #1215
zouxingyuks
wants to merge
3
commits into
TencentBlueKing:v1.7.x
from
zouxingyuks:feature/global-config-v2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
zouxingyuks
force-pushed
the
feature/global-config-v2
branch
from
December 20, 2024 08:07
ca48f3d
to
9dbdfa4
Compare
zouxingyuks
force-pushed
the
feature/global-config-v2
branch
from
December 20, 2024 08:07
9dbdfa4
to
8520b94
Compare
zouxingyuks
force-pushed
the
feature/global-config-v2
branch
from
December 20, 2024 08:21
57c78b3
to
ff0b6b0
Compare
chenjr15
approved these changes
Dec 25, 2024
yangfan-njupt
suggested changes
Jan 3, 2025
return a.(string) | ||
case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64, | ||
reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64: | ||
return fmt.Sprintf("%d", a) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个和 %v 不是等价的么,这个拆分和原版的区别是?
case reflect.Float32, reflect.Float64: | ||
return fmt.Sprintf("%f", a) | ||
case reflect.Slice, reflect.Array: | ||
return fmt.Sprintf("%v", a) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch需要default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.