-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a LayerStyle for drawing background blur effects. #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hparty
requested review from
kevingpqi123,
domchen and
shlzxjp
as code owners
January 23, 2025 02:19
domchen
changed the title
Support backgroundBlurStyle.
Add a LayerStyle for drawing background blur effects.
Jan 23, 2025
domchen
reviewed
Jan 23, 2025
domchen
reviewed
Jan 23, 2025
domchen
reviewed
Jan 23, 2025
domchen
reviewed
Jan 23, 2025
domchen
reviewed
Jan 23, 2025
domchen
reviewed
Jan 23, 2025
domchen
reviewed
Jan 24, 2025
src/layers/Layer.cpp
Outdated
Comment on lines
857
to
867
for (const auto& layerStyle : _layerStyles) { | ||
if (layerStyle->extraSourceType() == LayerStyleExtraSourceType::Contour) { | ||
needContour = true; | ||
} else if (!forBackground && | ||
layerStyle->extraSourceType() == LayerStyleExtraSourceType::Background) { | ||
// in background mode, we should not collect background image. | ||
needBackground = true; | ||
} | ||
if (needContour && (forBackground || needBackground)) { | ||
break; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
拆开写吧
domchen
reviewed
Jan 24, 2025
src/layers/Layer.cpp
Outdated
Comment on lines
914
to
920
if (layerStyle->extraSourceType() == LayerStyleExtraSourceType::Contour && contour != nullptr) { | ||
layerStyle->drawWithExtraSource(canvas, source->content, source->contentScale, contour, | ||
contourOffset, alpha); | ||
} else if (layerStyle->extraSourceType() == LayerStyleExtraSourceType::Background && | ||
background != nullptr) { | ||
layerStyle->drawWithExtraSource(canvas, source->content, source->contentScale, background, | ||
backgroundOffset, alpha); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果require不满足就不执行LayerStyle的draw
domchen
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持backgroundBlurStyle