Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Dialog): add dialogCard #5002

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

feat(Dialog): add dialogCard #5002

wants to merge 17 commits into from
+333 −127

Conversation

Wesley-0808
Copy link
Contributor

@Wesley-0808 Wesley-0808 commented Feb 9, 2025 •
edited
Loading

close #5017

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(Dialog): 新增dialogCard组件，用于非脱离文档流场景

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025 •
edited
Loading

失败

@Wesley-0808
Copy link
Contributor Author

@uyarn 帮忙看看为啥test不过，谢谢

@liweijie0812
Copy link
Collaborator

/update-snapshot

@github-actions GitHub Actions
Copy link
Contributor

⏳ 正在运行快照更新。。。 CI: Open

@Wesley-0808
Copy link
Contributor Author

/update-snapshot

似乎这个CI有点问题

@liweijie0812
Copy link
Collaborator

liweijie0812 commented Feb 10, 2025 •
edited
Loading

没事，我推了新 PR 改了 ，你先本地运行 pnpm test:update 更新快照

@uyarn uyarn changed the title feat: dialogCard feat(Dialog): add dialogCard Feb 11, 2025
@Wesley-0808 Wesley-0808 mentioned this pull request Feb 14, 2025
Open
@Wesley-0808 Wesley-0808 deleted the feat/dialogCard branch February 14, 2025 14:21
@Wesley-0808
Copy link
Contributor Author

c 误操作了

@Wesley-0808 Wesley-0808 restored the feat/dialogCard branch February 14, 2025 14:48
@Wesley-0808 Wesley-0808 reopened this Feb 14, 2025
@uyarn
Copy link
Collaborator

uyarn commented Feb 19, 2025

/update-snapshot

@github-actions GitHub Actions
Copy link
Contributor

⏳ 正在运行快照更新。。。 CI: Open

@uyarn
Copy link
Collaborator

uyarn commented Feb 19, 2025

/update-snapshot

@github-actions GitHub Actions
Copy link
Contributor

⏳ 正在运行快照更新。。。 CI: Open

@uyarn
Copy link
Collaborator

uyarn commented Feb 19, 2025

/update-snapshot

@github-actions GitHub Actions
Copy link
Contributor

⏳ 正在运行快照更新。。。 CI: Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uyarn uyarn uyarn left review comments

@PengYYYYY PengYYYYY Awaiting requested review from PengYYYYY PengYYYYY is a code owner

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@xiaosansiji xiaosansiji Awaiting requested review from xiaosansiji xiaosansiji is a code owner

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@LeeJim LeeJim Awaiting requested review from LeeJim LeeJim is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dialog] DialogCard
3 participants
@Wesley-0808 @liweijie0812 @uyarn