Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PullDownRefresh): reset loading bar height #888

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

ccccpj
Copy link
Collaborator

@ccccpj ccccpj commented Jun 19, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #801

💡 需求背景和解决方案

📝 更新日志

  • fix(PullDownRefresh): 修复下拉刷新加载样式未居中问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@ccccpj ccccpj requested review from LeeJim and anlyyao June 19, 2023 02:30
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023

完成

@github-actions
Copy link
Contributor

Size Change: +174 B (0%)

Total Size: 473 kB

Filename Size Change
./dist/tdesign.js 276 kB +106 B (0%)
./dist/tdesign.min.js 133 kB +68 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 36.4 kB
./dist/tdesign.min.css 26.2 kB

@ccccpj ccccpj force-pushed the fix/pull-down-refresh-bug-230619 branch from 500c00d to ed608e7 Compare June 19, 2023 02:58
@github-actions
Copy link
Contributor

Size Change: +174 B (0%)

Total Size: 473 kB

Filename Size Change
./dist/tdesign.js 276 kB +106 B (0%)
./dist/tdesign.min.js 133 kB +68 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 36.4 kB
./dist/tdesign.min.css 26.2 kB

@anlyyao
Copy link
Collaborator

anlyyao commented Jun 20, 2023

@ccccpj 刷新完成后的“提示文本”没居中

@ccccpj ccccpj force-pushed the fix/pull-down-refresh-bug-230619 branch from ed608e7 to 0e49e4f Compare June 20, 2023 13:42
@ccccpj
Copy link
Collaborator Author

ccccpj commented Jun 20, 2023

@ccccpj 刷新完成后的“提示文本”没居中

Tencent/tdesign-common#1417

@ccccpj ccccpj force-pushed the fix/pull-down-refresh-bug-230619 branch 2 times, most recently from a56717d to e17e2cc Compare June 20, 2023 13:54
@ccccpj ccccpj force-pushed the fix/pull-down-refresh-bug-230619 branch from e17e2cc to 64392db Compare June 20, 2023 13:56
@github-actions
Copy link
Contributor

Size Change: +184 B (0%)

Total Size: 473 kB

Filename Size Change
./dist/tdesign.js 276 kB +107 B (0%)
./dist/tdesign.min.js 133 kB +77 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 36.4 kB
./dist/tdesign.min.css 26.3 kB

2 similar comments
@github-actions
Copy link
Contributor

Size Change: +184 B (0%)

Total Size: 473 kB

Filename Size Change
./dist/tdesign.js 276 kB +107 B (0%)
./dist/tdesign.min.js 133 kB +77 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 36.4 kB
./dist/tdesign.min.css 26.3 kB

@github-actions
Copy link
Contributor

Size Change: +184 B (0%)

Total Size: 473 kB

Filename Size Change
./dist/tdesign.js 276 kB +107 B (0%)
./dist/tdesign.min.js 133 kB +77 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/reset.css 672 B
./dist/tdesign.css 36.4 kB
./dist/tdesign.min.css 26.3 kB

@anlyyao anlyyao merged commit 1bbd645 into develop Jun 25, 2023
@anlyyao anlyyao deleted the fix/pull-down-refresh-bug-230619 branch June 25, 2023 09:15
This was referenced Jun 27, 2023
anlyyao added a commit that referenced this pull request Jun 28, 2023
* fix(PullDownRefresh): reset loading bar height (#888)

* refactor(fab): using setup (#897)

* chore: fix ci test (#904)

* fix: resolve some test case error (#905)

* fix(Textarea): resolved indicator error (#902)

* fix(Textarea): resolved indicator error

* test: update unit case

* feat(Popover): add popover (#898)

* feat(Popover): add popover

* chore: update _common

* test: update snapshots

* fix: remove use-emit-event function (#899)

* fix: remove use-emit-event function

* fix: remove use-emit-event function

* feat(stepper): add focus event

* test: resolve error

* test: update snapshot

* refactor(divider): final version (#896)

* refactor(divider): final version

* test: update snapshots

---------

Co-authored-by: anlyyao <[email protected]>

* fix(Search): resolved action-click event invalid (#908)

* fix(DateTimePicker): fix modelValue invalid (#903)

* chore: publish v1.0.0-rc (#910)

* chore: publish v1.0.0-rc

* docs: update changelog

---------

Co-authored-by: ccccpj <[email protected]>
Co-authored-by: leejimchill <[email protected]>
Co-authored-by: yuyang <[email protected]>
anlyyao added a commit that referenced this pull request Jul 4, 2023
* fix(PullDownRefresh): reset loading bar height (#888)

* refactor(fab): using setup (#897)

* chore: fix ci test (#904)

* fix: resolve some test case error (#905)

* fix(Textarea): resolved indicator error (#902)

* fix(Textarea): resolved indicator error

* test: update unit case

* feat(Popover): add popover (#898)

* feat(Popover): add popover

* chore: update _common

* test: update snapshots

* fix: remove use-emit-event function (#899)

* fix: remove use-emit-event function

* fix: remove use-emit-event function

* feat(stepper): add focus event

* test: resolve error

* test: update snapshot

* refactor(divider): final version (#896)

* refactor(divider): final version

* test: update snapshots

---------

Co-authored-by: anlyyao <[email protected]>

* fix(Search): resolved action-click event invalid (#908)

* fix(DateTimePicker): fix modelValue invalid (#903)

* chore: publish v1.0.0-rc (#910)

* chore: publish v1.0.0-rc

* docs: update changelog

* fix(Stepper): resolved precision problem (#906)

* feat: remove discard api (#907)

* docs: add EN docs for mobile (#914)

* feat(Popover): support close-on-click-outside attr (#916)

* feat(Loading): enrich the supported types of indicator properties (#918)

* feat(Loading): enrich the supported types of indicator properties

* test: update snapshots

* feat(cascader): lazy demo (#917)

* feat(cascader): lazy demo

* feat: cascader options change 事件

* feat(cascader): lazy demo update

* fix: fix demo

---------

Co-authored-by: PY <[email protected]>
Co-authored-by: anlyyao <[email protected]>

* fix: remove unused code (#921)

* feat(dropdownMenu): add direction api (#878)

* feat(dropdownMenu): add direction api

* fix: optimize demo code

---------

Co-authored-by: leejimchill <[email protected]>

* fix(Popup): resolved visible-change event parameter error (#920)

* chore: update _common (#922)

* chore: publish v1.0.0-rc.1 (#925)

* chore: publish v1.0.0-rc.1

* docs: update changelog

---------

Co-authored-by: ccccpj <[email protected]>
Co-authored-by: leejimchill <[email protected]>
Co-authored-by: yuyang <[email protected]>
Co-authored-by: PY <[email protected]>
@github-actions github-actions bot mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PullDownRefresh] 刷新展示的位置未剧中
2 participants