feat(radio): 重构radio dom接口,补充对应文档和适配样式 #468
Open
+2,304
−315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HaixingOoO
reviewed
Aug 20, 2024
HaixingOoO
reviewed
Aug 20, 2024
HaixingOoO
reviewed
Aug 20, 2024
HaixingOoO
reviewed
Aug 20, 2024
byq1213
force-pushed
the
feat/radio_0817
branch
2 times, most recently
from
382d560
to
fa6d0ab
Compare
byq1213
force-pushed
the
feat/radio_0817
branch
from
fa6d0ab
to
89ddd3d
Compare
anlyyao
reviewed
Sep 18, 2024
| @@ -1,4 +1,2 @@ | |||
| import '../../_common/style/mobile/components/radio/_index.less'; | |||
| import '../../_common/style/mobile/components/radio/v2/_index.less'; | |||
| import '../../_common/style/mobile/components/radio-group/_index.less'; | |||
There was a problem hiding this comment.
radio-group 的样式没有实际意义了，可移除
| allowUncheck = false, | ||
| checked = false, | ||
| defaultChecked = false, | ||
| children, |
There was a problem hiding this comment.
children 需要保留。 type.ts文件缺少了该属性，辛苦重新从api平台生成
| import classNames from 'classnames'; | ||
| import { CheckIcon } from 'tdesign-icons-react'; | ||
| import { CheckIcon, CheckCircleFilledIcon } from 'tdesign-icons-react'; | ||
| import forwardRefWithStatics from '../_util/forwardRefWithStatics'; | ||
| import useConfig from '../_util/useConfig'; |
There was a problem hiding this comment.
改用 usePrefixClass() 计算组件类名前缀
There was a problem hiding this comment.
const radioClass = usePrefixClass('radio');
| {content && ( | ||
| <div | ||
| className={`${classPrefix}__description ${disabled && `${classPrefix}__description--disabled`}`} | ||
| style={getLimitRow(maxContentRow)} |
| <div className={iconClass}>{renderIcon()}</div> | ||
| <div className={`${classPrefix}__content`}> | ||
| {label && ( | ||
| <span className={titleClassName} style={labelStyle}> |
There was a problem hiding this comment.
style={{ WebkitLineClamp: maxLabelRow }} 就好， 其他的在样式文件里面处理了
| > | ||
| <CheckIcon size={16} /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| const labelStyle = { |
| @@ -18,12 +18,23 @@ export interface TdRadioProps { | |||
| * @default false | |||
| */ | |||
| allowUncheck?: boolean; | |||
There was a problem hiding this comment.
allowUncheck 属性功能未实现，需要补充实现
| * 是否允许取消选中 | ||
| * @default false | ||
| */ | ||
| allowUncheck?: boolean; |
There was a problem hiding this comment.
radio-group的allowUncheck属性功能也未实现，需要补齐
|
@byq1213 API文档需要从tdesign-api平台重新生成，补充了 readonly 属性 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #461
🤔 这个 PR 的性质是？
🔗 相关 Issue
fix #461
💡 需求背景和解决方案
📝 更新日志
fix(组件名称): 处理问题或特性描述 ...
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单