Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(voltron): resolve voltron build error #4018

Merged
merged 1 commit into from
Sep 4, 2024
Merged

build(voltron): resolve voltron build error #4018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions framework/voltron/core/src/bridge/bridge_ffi_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,6 @@ EXTERN_C void DoBindDomAndRender(uint32_t dom_manager_id, int32_t engine_id, uin
}

scope->SetDomManager(dom_manager);
scope->SetRenderManager(render_manager);
dom_manager->SetRenderManager(render_manager);
render_manager->SetDomManager(dom_manager);
render_manager->BindBridgeId(engine_id);
Expand Down Expand Up @@ -330,8 +329,9 @@ EXTERN_C void DoConnectRootViewAndRuntime(int32_t engine_id, uint32_t root_id) {
}
#endif

auto dom_manager = scope->GetDomManager().lock();
std::shared_ptr<voltron::VoltronRenderManager> render_manager =
std::static_pointer_cast<voltron::VoltronRenderManager>(scope->GetRenderManager().lock());
std::static_pointer_cast<voltron::VoltronRenderManager>(dom_manager->GetRenderManager().lock());

float density = render_manager->GetDensity();
auto layout_node = root_node->GetLayoutNode();
Expand Down
Loading