feat(android): support fcp monitor #3796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siguangli
requested review from
iPel,
etkmao,
ilikethese and
zealotchen0
as code owners
github-actions
bot
added
framework: android
driver: js
renderer: native
module: android
size: m
|
Hi, @siguangli. Thanks for your PR! 👏 🏷️ You can leave a comment in this PR with |
zealotchen0
reviewed
Mar 27, 2024
| @@ -108,13 +108,16 @@ public class NativeRenderer extends Renderer implements NativeRender, NativeRend | |||
| private static final String EVENT_PREFIX = "on"; | |||
| private static final String SNAPSHOT_CREATE_NODE = "createNode"; | |||
| private static final String SNAPSHOT_UPDATE_LAYOUT = "updateLayout"; | |||
| private static final String FCP_KEY = "paintType"; | |||
There was a problem hiding this comment.
这是是不是叫 PAINT_KEY 和 PAINT_VALUE 好点
iPel
reviewed
Mar 27, 2024
...k/android/src/main/java/com/tencent/mtt/hippy/adapter/monitor/HippyEngineMonitorAdapter.java
Show resolved
Hide resolved
|
Please check the following details: |
hippy-actions
bot
added
action(squash-merge): failed
iPel
approved these changes
Mar 27, 2024
zealotchen0
approved these changes
Mar 27, 2024
zealotchen0
added
action(squash-merge)
wwwcg
pushed a commit
to wwwcg/Hippy
that referenced
this pull request
Apr 17, 2024
* feat(android): support fcp monitor * fix(android): rename to PAINT_TYPE_KEY --------- Co-authored-by: maxli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a new pull request, please make sure: