Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): JSCCtx CreateObject crash protect #3632

Merged
merged 2 commits into from
Nov 23, 2023
Merged

fix(core): JSCCtx CreateObject crash protect #3632

merged 2 commits into from
Nov 23, 2023

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Nov 23, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@etkmao etkmao requested a review from ilikethese as a code owner November 23, 2023 07:36
@github-actions github-actions bot added driver: js size: xs Denotes a PR that changes 0-9 lines labels Nov 23, 2023
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 23, 2023

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

ilikethese
ilikethese previously approved these changes Nov 23, 2023
View reviewed changes
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 23, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 23, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) November 23, 2023 07:42
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 23, 2023
@etkmao etkmao requested a review from ilikethese November 23, 2023 07:43
@hippy-actions hippy-actions bot merged commit d4026a2 into Tencent:main Nov 23, 2023
23 checks passed
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 23, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilikethese ilikethese ilikethese approved these changes

Assignees
No one assigned
Labels
driver: js size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etkmao @ilikethese