Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): make TextInput default color same as iOS #3613

Merged
merged 2 commits into from
Dec 5, 2023
Merged

feat(android): make TextInput default color same as iOS #3613

merged 2 commits into from
Dec 5, 2023

Conversation

iPel
Copy link
Collaborator

@iPel iPel commented Nov 16, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@iPel iPel requested a review from siguangli as a code owner November 16, 2023 10:36
@github-actions github-actions bot added renderer: native size: s Denotes a PR that changes 10-99 lines labels Nov 16, 2023
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 16, 2023

Hi, @iPel. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@iPel iPel force-pushed the textinput_default_color branch from ea208d9 to dd9eebd Compare November 24, 2023 06:06
@iPel iPel added the consistency consistency between android and ios label Nov 28, 2023
@iPel iPel force-pushed the textinput_default_color branch from dd9eebd to 4d36c70 Compare November 30, 2023 03:21
@hippy-service Hippy Service
Copy link

hippy-service bot commented Dec 5, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Dec 5, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) December 5, 2023 02:27
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Dec 5, 2023
@siguangli siguangli added the action(squash-merge) Squash and merge action label Dec 5, 2023
@hippy-actions hippy-actions bot disabled auto-merge December 5, 2023 02:28
@hippy-actions hippy-actions bot enabled auto-merge (squash) December 5, 2023 02:28
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Dec 5, 2023
@hippy-actions hippy-actions bot merged commit 24d11f9 into Tencent:main Dec 5, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siguangli siguangli siguangli approved these changes

Assignees
No one assigned
Labels
consistency consistency between android and ios renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iPel @siguangli @open-hippy