Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trickle-ice case #1

Closed
wants to merge 1 commit into from
Closed

trickle-ice case #1

wants to merge 1 commit into from

Conversation

LewisYinLIU
Copy link

Case modified for url structure test when iceserver creation.

@johache
Copy link

johache commented Jan 27, 2015

  • Make a branch instead of a fork.
  • Since you made a nice modification of trickle-ice, instead of a brutal copy, you should PR the changes on this page instead of a copy (.../content/peerconnection/trickle-ice/...)
  • DO NOT push pages that use an adapter local to the repo. EVER. Instead include a version from our CDN. See the include from the original trickle-ice

@johache
Copy link

johache commented Jan 27, 2015

You created a second pull request, please close this one

@LewisYinLIU
Copy link
Author

OK i will, just found another bug trying to fix and then test the "hascredential" problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LewisYinLIU @johache