Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new option to allow other SDKs to suppress reserved key warnings #221

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add new option to allow other SDKs to suppress reserved key warnings #221

wants to merge 1 commit into from

Conversation

Jeehut
Copy link
Contributor

@Jeehut Jeehut commented Dec 23, 2024

Fixes #220

@winsmith The git diff for TelemetryClient looks like I changed more, but I actually only added the check if configuration.reservedParameterWarningsEnabled and indented the rest as-is inside it's body.

@Jeehut Jeehut requested a review from winsmith December 23, 2024 08:38
@Jeehut Jeehut mentioned this pull request Dec 23, 2024
Open
kkostov
kkostov approved these changes Dec 23, 2024
View reviewed changes
Copy link

@kkostov kkostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome @Jeehut, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkostov kkostov kkostov approved these changes

@winsmith winsmith Awaiting requested review from winsmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow suppressing reserved prefix warning
2 participants
@Jeehut @kkostov