Remove the old “newSessionBegan” signal #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We’re usually sending old-style parameter names in parallel with the new-style parameter so that people who switch from SDK version 1 to 2 have an easier and smoother upgrade path. However, this leads to problems with customers with lots of users, because they get twice as many session signals now. Since not too many customers rely on session signals right now, I’d suggest we just do a hard switch in this case and deal with the slightly increased support load by offering customers who write in abou this updated queries.
|
@Jeehut I'd love to hear your opinion on this. |
Jeehut
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’re usually sending old-style parameter names in parallel with the new-style parameter so that people who switch from SDK version 1 to 2 have an easier and smoother upgrade path.
However, this leads to problems with customers with lots of users, because they get twice as many session signals now.
Since not too many customers rely on session signals right now, I’d suggest we just do a hard switch in this case and deal with the slightly increased support load by offering customers who write in abou this updated queries.