Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience methods & types for sending error & purchase preset signals #154

Merged
merged 6 commits into from
Jun 2, 2024

Conversation

Jeehut
Copy link
Contributor

@Jeehut Jeehut commented May 18, 2024

This should be merged together with TelemetryDeck/docs#82.

@Jeehut Jeehut changed the title Add convenience methods & types for sending error preset signals Add convenience methods & types for sending error & purchase preset signals May 18, 2024
@Jeehut
Copy link
Contributor Author

Jeehut commented May 18, 2024

@winsmith This should be merge-ready now.

@Jeehut Jeehut force-pushed the feature/presets branch from a82bcb5 to 1417aa9 Compare May 18, 2024 12:44
@Jeehut Jeehut force-pushed the feature/grand-rename branch 2 times, most recently from 23b957f to 3a45e61 Compare May 23, 2024 19:25
@Jeehut Jeehut force-pushed the feature/presets branch from 2f19b67 to 6557f80 Compare May 23, 2024 19:30
@Jeehut Jeehut requested a review from winsmith May 23, 2024 19:30
@Jeehut Jeehut changed the base branch from feature/grand-rename to main May 28, 2024 15:10
@Jeehut Jeehut changed the base branch from main to feature/grand-rename May 28, 2024 15:10
@Jeehut Jeehut force-pushed the feature/presets branch from 6557f80 to 1db5ef4 Compare May 31, 2024 18:17
@Jeehut Jeehut changed the base branch from feature/grand-rename to main May 31, 2024 18:17
Copy link
Contributor

@winsmith winsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, and well-documented! Go!

@mattcorey
Copy link

Any schedule for when this will be merged? 🙏

@Jeehut
Copy link
Contributor Author

Jeehut commented Jun 2, 2024

@mattcorey Merging and releasing now (had a busy family weekend). 🎉

@Jeehut Jeehut merged commit e324bd7 into main Jun 2, 2024
@Jeehut Jeehut deleted the feature/presets branch June 2, 2024 21:36
@mattcorey
Copy link

Thank you!! (and so sorry if I came off as pushy! 🙏 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants