Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add question to faq about concurrency of updates #117

Open
wants to merge 87 commits into
base: develop
Choose a base branch
from

Conversation

elementh
Copy link

This knowledge is not easily available, and it's not what you would expect that will happen when using webhooks, specially with ASP.NET Core.

Let me know if the format is not correct or if more changes are needed.

PD: I've made the PR towards develop, as specified in the CONTRIBUTING.md, since it seems that it hasn't been used in a long time, there are extra commits bundled in this PR (I've only authored 3). Let me know if you want me to change this towards master.

wiz0u added 30 commits June 26, 2024 18:00
Added Forward/Copy/Delete and other improvements
@elementh
Copy link
Author

elementh commented Sep 5, 2024

@wiz0u any input? 😃

@wiz0u
Copy link
Member

wiz0u commented Sep 6, 2024

what is this mess? XD
why a PR from last week shows a lot of old commits?

@wiz0u
Copy link
Member

wiz0u commented Sep 6, 2024

you probably forked your repo a long time ago and only made the changes recently or something

@wiz0u
Copy link
Member

wiz0u commented Sep 6, 2024

ok I've seen the differences directly on your repo

My opinion is that FAQ must be frequent.
I'd rather not have anybody contribute directly to FAQ, but rather ask their question in the group, and if it becomes a frequent question, I will add it to the FAQ.

Now your point for Q28 is still interesting so it could be added directly in webhook.md.
I suggest you close this PR, close your fork. Then go directly online at https://github.com/TelegramBots/book/edit/master/src/3/updates/webhook.md
and insert your change directly in there (you should be able to commit it online automatically as a branch+PR)

I also suggest you merge your stuff within the existing block that speak on a similar matter:

  • If your update handler throws an exception or takes too much time to return,
    Telegram will consider it a temporary failure and will RESEND the same update a bit later.
    You may want to prevent handling the same update.Id twice:

@elementh
Copy link
Author

elementh commented Sep 6, 2024

you probably forked your repo a long time ago and only made the changes recently or something

No, I simply did the PR towards develop (as CONTRIBUTING.md says), but you've been committing directly to main/master 😂

@wiz0u
Copy link
Member

wiz0u commented Sep 6, 2024

I reread your stuff, no need to merge to existing block as I said, add it at the end

@elementh
Copy link
Author

elementh commented Sep 6, 2024

ok I've seen the differences directly on your repo

My opinion is that FAQ must be frequent.

I'd rather not have anybody contribute directly to FAQ, but rather ask their question in the group, and if it becomes a frequent question, I will add it to the FAQ.

Now your point for Q28 is still interesting so it could be added directly in webhook.md.

I suggest you close this PR, close your fork. Then go directly online at https://github.com/TelegramBots/book/edit/master/src/3/updates/webhook.md

and insert your change directly in there (you should be able to commit it online automatically as a branch+PR)

I also suggest you merge your stuff within the existing block that speak on a similar matter:

  • If your update handler throws an exception or takes too much time to return,

Telegram will consider it a temporary failure and will RESEND the same update a bit later.

You may want to prevent handling the same update.Id twice:

Will check it during the weekend, thanks for the feedback 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants