Simplify build instructions #448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeruf
force-pushed
the
readme-build-instructions
branch
2 times, most recently
from
cdb0a02
to
46022f3
Compare
thermatk
force-pushed
the
master
branch
2 times, most recently
from
bc92b08
to
b8b05a2
Compare
thermatk
force-pushed
the
master
branch
5 times, most recently
from
f123a11
to
bef1a79
Compare
thermatk
force-pushed
the
master
branch
3 times, most recently
from
01470b4
to
e4029df
Compare
…FOSS-Team#436) Error when using newer version of ffmpeg: Upon further investigation, this error comes from newer versions of FFmpeg [1] as the packet read callback's expected return value on EOF has been changed. This commit fixes the issue by updating the packet read callback used to play videos with FFmpeg to return AVERROR_EOF on EOF instead of 0 as seen in mpv [2]. [1] https://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=a606f27f4c610708fa96e35eed7b7537d3d8f712 [2] mpv-player/mpv@e9dc4ac
I guess upstream did the same and forgot to document. isom.h is included in a form patched to stop annoying the compiler, dv.h in the original form
thermatk
force-pushed
the
master
branch
3 times, most recently
from
69a2691
to
212f140
Compare
thermatk
force-pushed
the
master
branch
2 times, most recently
from
06bbe60
to
e7535cc
Compare
thermatk
force-pushed
the
master
branch
2 times, most recently
from
093ca61
to
d4bd461
Compare
thermatk
force-pushed
the
master
branch
2 times, most recently
from
e1c9e2b
to
ed5f703
Compare
thermatk
force-pushed
the
master
branch
3 times, most recently
from
a310576
to
9219dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
build.shscript that handles all the JNI stuff, trying to auto-detect paths.Makes the instructions a bit prettier.