Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NakedCard): add support for top icon #836

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

atabel
Copy link
Collaborator

@atabel atabel commented Jul 28, 2023

@github-actions
Copy link

Size stats

master this branch diff
Total JS 9.39 MB 9.39 MB +901 B
JS without icons 910 kB 911 kB +901 B
Lib overhead 127 kB 127 kB 0 B
Lib overhead (gzip) 32.8 kB 32.8 kB 0 B

@github-actions
Copy link

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-93l8wo9l1-tuentisre.vercel.app

Built with commit 047235d.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@pladaria
Copy link
Member

The PR title should be updated to "asset support" or something like that. The image was already supported

@atabel atabel changed the title feat(NakedCard): add support for top image feat(NakedCard): add support for top icon Aug 3, 2023
@atabel atabel added this pull request to the merge queue Aug 3, 2023
Merged via the queue into master with commit f438079 Aug 3, 2023
10 checks passed
@atabel atabel deleted the atoledano-asset-in-naked-card branch August 3, 2023 08:50
tuentisre pushed a commit that referenced this pull request Aug 11, 2023
# [14.20.0](v14.19.0...v14.20.0) (2023-08-11)

### Bug Fixes

* **AdvancedDataCard:** avoid content overflow with top actions ([#839](#839)) ([a1eae2d](a1eae2d))
* **AdvancedDataCard:** Fix Touchable layout, extras positioning, closable DOM position... ([#833](#833)) ([21dea84](21dea84))
* **AdvancedDataCard:** touchable area didn't cover the whole card in some cases ([#847](#847)) ([31ec606](31ec606))
* **ButtonLink:** add aligned prop back until next major release ([#846](#846)) ([3de841c](3de841c))
* **Tabs:** style fixes and align with design spec ([#832](#832)) ([37de417](37de417))

### Features

* **ButtonLink:** scale chevron according to font size ([#849](#849)) ([b69b651](b69b651))
* **Icons:** new Subtract icons ([#845](#845)) ([5f0a5f0](5f0a5f0))
* **NakedCard:** add support for top icon ([#836](#836)) ([f438079](f438079))
* **PosterCard:** allow backgroundColor/variant ([#841](#841)) ([f8e1f37](f8e1f37))
* **Row,BoxedRow:** add pressed style to list rows ([#838](#838)) ([8437198](8437198))
* **skin:** update design tokens ([#851](#851)) ([544f812](544f812))
* **SnapCard, DataCard, DisplayDataCard:** add aspect ratio support ([#848](#848)) ([b3e1639](b3e1639))
* **Title:** add tokens for Title2 and create Title3 ([#835](#835)) ([e218ba1](e218ba1))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 14.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants