Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tabs): style fixes and align with design spec #832

Merged
merged 6 commits into from
Aug 2, 2023

Conversation

marcoskolodny
Copy link
Collaborator

@marcoskolodny marcoskolodny commented Jul 27, 2023

Updating Tabs to align with specs requirements and code cleanup.

Issue: Link
Specs: Link

@github-actions
Copy link

github-actions bot commented Jul 27, 2023

Size stats

master this branch diff
Total JS 9.39 MB 9.39 MB +228 B
JS without icons 908 kB 909 kB +228 B
Lib overhead 127 kB 127 kB 0 B
Lib overhead (gzip) 32.8 kB 32.8 kB 0 B

@github-actions
Copy link

github-actions bot commented Jul 27, 2023

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-5fdfyvo7w-tuentisre.vercel.app

Built with commit b88a279.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Jul 27, 2023

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@marcoskolodny marcoskolodny marked this pull request as ready for review July 28, 2023 00:49
@AnaMontes11

This comment was marked as resolved.

atabel

This comment was marked as resolved.

@AnaMontes11

This comment was marked as resolved.

Copy link
Contributor

@AnaMontes11 AnaMontes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@atabel atabel added this pull request to the merge queue Aug 2, 2023
@atabel atabel removed this pull request from the merge queue due to a manual request Aug 2, 2023
@atabel atabel changed the title feat(Tabs): new updates in Tab component fix(Tabs): style fixes and align with design spec Aug 2, 2023
@atabel atabel added this pull request to the merge queue Aug 2, 2023
Merged via the queue into master with commit 37de417 Aug 2, 2023
10 checks passed
@atabel atabel deleted the WEB-1459-tabs-update branch August 2, 2023 15:42
tuentisre pushed a commit that referenced this pull request Aug 11, 2023
# [14.20.0](v14.19.0...v14.20.0) (2023-08-11)

### Bug Fixes

* **AdvancedDataCard:** avoid content overflow with top actions ([#839](#839)) ([a1eae2d](a1eae2d))
* **AdvancedDataCard:** Fix Touchable layout, extras positioning, closable DOM position... ([#833](#833)) ([21dea84](21dea84))
* **AdvancedDataCard:** touchable area didn't cover the whole card in some cases ([#847](#847)) ([31ec606](31ec606))
* **ButtonLink:** add aligned prop back until next major release ([#846](#846)) ([3de841c](3de841c))
* **Tabs:** style fixes and align with design spec ([#832](#832)) ([37de417](37de417))

### Features

* **ButtonLink:** scale chevron according to font size ([#849](#849)) ([b69b651](b69b651))
* **Icons:** new Subtract icons ([#845](#845)) ([5f0a5f0](5f0a5f0))
* **NakedCard:** add support for top icon ([#836](#836)) ([f438079](f438079))
* **PosterCard:** allow backgroundColor/variant ([#841](#841)) ([f8e1f37](f8e1f37))
* **Row,BoxedRow:** add pressed style to list rows ([#838](#838)) ([8437198](8437198))
* **skin:** update design tokens ([#851](#851)) ([544f812](544f812))
* **SnapCard, DataCard, DisplayDataCard:** add aspect ratio support ([#848](#848)) ([b3e1639](b3e1639))
* **Title:** add tokens for Title2 and create Title3 ([#835](#835)) ([e218ba1](e218ba1))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 14.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants