Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Cards): CardAction type #831

Merged
merged 5 commits into from
Jul 27, 2023
Merged

fix(Cards): CardAction type #831

merged 5 commits into from
Jul 27, 2023

Conversation

atabel
Copy link
Collaborator

@atabel atabel commented Jul 26, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 26, 2023 •
edited
Loading

Size stats

master this branch diff
Total JS 9.39 MB 9.39 MB -118 B
JS without icons 909 kB 909 kB -170 B
Lib overhead 127 kB 127 kB 0 B
Lib overhead (gzip) 32.8 kB 32.8 kB 0 B

@github-actions
Copy link

github-actions bot commented Jul 26, 2023 •
edited
Loading

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-gavbglthb-tuentisre.vercel.app

Built with commit c16c335.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Jul 26, 2023 •
edited
Loading

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

atabel
atabel commented Jul 26, 2023
View reviewed changes
src/card.css.ts
@@ -391,21 +391,6 @@ export const cardActionMedia = style([
},
]);

export const videoAction = style([
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not being used :/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic became obsolete when we changed the hover/active states, and the top action for the cards with videos/images became more generic. Before that, the top action for videos used to have a different style (this one), and it was used in line 306 of src/card.tsx.

Good catch!

@atabel atabel added this pull request to the merge queue Jul 27, 2023
Merged via the queue into master with commit 6631788 Jul 27, 2023
10 checks passed
@atabel atabel deleted the atoledano-fix-card-top-actions-type branch July 27, 2023 14:52
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 14.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

tuentisre pushed a commit that referenced this pull request Jul 28, 2023
@semantic-release-bot
chore(release): 14.19.0 [skip ci]
acfa9e4 
# [14.19.0](v14.18.2...v14.19.0) (2023-07-28)

### Bug Fixes

* **ButtonLink, Title:** update alignments ([#829](#829)) ([87bd3e3](87bd3e3))
* **Cards:** CardAction type ([#831](#831)) ([6631788](6631788))

### Features

* **MediaCard:** add top icon support ([#824](#824)) ([e9a79a3](e9a79a3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pladaria pladaria pladaria approved these changes

@Winde Winde Winde approved these changes

@marcoskolodny marcoskolodny marcoskolodny approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atabel @tuentisre @pladaria @Winde @marcoskolodny