feat(Header): small version, allow removing vertical padding #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 274be5e. |
atabel
commented
Jul 18, 2023
| @@ -19,6 +20,26 @@ const colorProperties = defineProperties({ | |||
|
|
|||
| const sizes = [0, 2, 4, 8, 12, 16, 20, 24, 32, 40, 48, 56, 64, 72, 80] as const; | |||
|
|
|||
| const responsiveProperties = defineProperties({ | |||
There was a problem hiding this comment.
this allows us using responsive padding sprinkles:
sprinkles({padding: {mobile: 8, desktop: 16}})
yceballost
requested changes
Jul 18, 2023
pladaria
approved these changes
Jul 18, 2023
wyunreal
approved these changes
Jul 18, 2023
| <ResponsiveLayout isInverse={isInverse}> | ||
| <ResponsiveLayout | ||
| isInverse={isInverse} | ||
| dataAttributes={{'component-name': 'MainSectionHeaderLayout', ...dataAttributes}} |
There was a problem hiding this comment.
Maybe you can use getPrefixedDataAttributes here?
There was a problem hiding this comment.
no, that would be wrong. That's already done internally in ResponsiveLayout
marcoskolodny
approved these changes
Jul 18, 2023
yceballost
approved these changes
Jul 19, 2023
atabel
changed the title
tuentisre
pushed a commit
that referenced
this pull request
Jul 20, 2023
# [14.18.0](v14.17.1...v14.18.0) (2023-07-20) ### Bug Fixes * **DisplayMediaCard, PosterCard:** add label to video control ([#823](#823)) ([dc765ef](dc765ef)) * **row:** add missing dataAttributes ([#815](#815)) ([47e7cab](47e7cab)) ### Features * **AdvancedDataCard:** new community component ([#780](#780)) ([2803b9c](2803b9c)) * **Blocks:** new Mistica Community Components ([#770](#770)) ([8fc368a](8fc368a)) * **Header:** small version, allow removing vertical padding ([#822](#822)) ([448387e](448387e)) * **Nakedcard:** new component ([#819](#819)) ([688bb8e](688bb8e))
|
🎉 This PR is included in version 14.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira with specs: https://jira.tid.es/browse/WEB-1469
smallprop inHeaderto reduce the title/description font sizenoPaddingYprop toHeaderLayoutto remove the vertical padding (required by Novum CMS layout, which establishes its own paddings)StackandBoxcomponents:When using the responsive notation (object), setting both
mobileanddesktopis mandatory.tabletis optional, and will usemobilevalue by default when not specified.This will allow us to reduce the use of
useScreenSize()hook, which is problematic with SSR.In this PR I've applied this to header components, but we should do the same with the rest of components in Mística too. It's still pending to apply the same approach in
Inlinecomponent