Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Text): extract textProps to separate file #1267

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

pladaria
Copy link
Member

@pladaria pladaria commented Oct 9, 2024

To avoid breaking RSC

@Marcosld identified a problem using the Table component a RSC:

⨯ Error: Cannot access text2.desktopSize on the server. 
You cannot dot into a client module from a server component. You can only pass the imported name through.

Copy link

github-actions bot commented Oct 9, 2024

Size stats

master this branch diff
Total JS 12.1 MB 12.1 MB +79 B
JS without icons 1.94 MB 1.94 MB +79 B
Lib overhead 68.2 kB 68.2 kB +6 B
Lib overhead (gzip) 16.6 kB 16.6 kB -2 B

Copy link

github-actions bot commented Oct 9, 2024

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-4ivqqjise-flows-projects-65bb050e.vercel.app

Built with commit d503313.
This pull request is being automatically deployed with vercel-action

@Marcosld Marcosld self-requested a review October 9, 2024 14:04
@pladaria pladaria added this pull request to the merge queue Oct 16, 2024
Copy link

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

Merged via the queue into master with commit 3894eb9 Oct 16, 2024
11 checks passed
@pladaria pladaria deleted the pladaria/WEB-2073_rsc-table branch October 16, 2024 13:53
tuentisre pushed a commit that referenced this pull request Oct 16, 2024
# [16.3.0](v16.2.0...v16.3.0) (2024-10-16)

### Bug Fixes

* **Sheet:** lock focus inside sheet container when content is not interactive ([#1264](#1264)) ([dd0fdad](dd0fdad))
* **Text:** extract textProps to separate file ([#1267](#1267)) ([3894eb9](3894eb9))

### Features

* **Box:** remove className usages ([#1266](#1266)) ([56a25e0](56a25e0))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 16.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants