fix(Sheet): lock focus inside sheet container when content is not interactive #1264
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 36af032. |
atabel
reviewed
Oct 8, 2024
marcoskolodny
commented
Oct 8, 2024
| @@ -79,7 +79,7 @@ | |||
| "@swc/cli": "^0.1.62", | |||
| "@swc/core": "^1.3.95", | |||
| "@swc/jest": "^0.2.29", | |||
| "@telefonica/acceptance-testing": "5.0.0", | |||
| "@telefonica/acceptance-testing": "5.1.0", | |||
There was a problem hiding this comment.
unrelated, just upgrading this lib to have the changes in https://github.com/Telefonica/js-toolbox/pull/107
pladaria
approved these changes
Oct 9, 2024
atabel
approved these changes
Oct 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tuentisre
pushed a commit
that referenced
this pull request
Oct 16, 2024
# [16.3.0](v16.2.0...v16.3.0) (2024-10-16) ### Bug Fixes * **Sheet:** lock focus inside sheet container when content is not interactive ([#1264](#1264)) ([dd0fdad](dd0fdad)) * **Text:** extract textProps to separate file ([#1267](#1267)) ([3894eb9](3894eb9)) ### Features * **Box:** remove className usages ([#1266](#1266)) ([56a25e0](56a25e0))
|
🎉 This PR is included in version 16.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Link