feat(Logo): allow color override #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit e91f811. |
pladaria
requested review from
yceballost,
anabelengp,
marcoskolodny and
atabel
yceballost
approved these changes
Oct 7, 2024
src/__stories__/logo-story.tsx
Outdated
| @@ -78,6 +88,7 @@ Default.args = { | |||
| inverse: false, | |||
| forceBrandLogo: false, | |||
| brand: 'Movistar', | |||
| color: '', | |||
There was a problem hiding this comment.
instead of a empty box, I prefer to give a list of examples like in progress bar story
https://mistica-ekone7k5g-flows-projects-65bb050e.vercel.app/?path=/story/components-progress-bars--progress-bar-story
For example:
color: 'default' | 'neutralHigh' | 'neutralMedium' | '#000000';
marcoskolodny
approved these changes
Oct 7, 2024
atabel
approved these changes
Oct 8, 2024
anabelengp
approved these changes
Oct 8, 2024
tuentisre
pushed a commit
that referenced
this pull request
Oct 8, 2024
# [16.2.0](v16.1.1...v16.2.0) (2024-10-08) ### Bug Fixes * **Tooltip, Popover:** allow styling target wrapper ([#1262](#1262)) ([38abf25](38abf25)) * **Touchable:** make content focusable when using onPress + as="a" ([#1255](#1255)) ([5e297d5](5e297d5)) ### Features * **Align:** create component ([#1254](#1254)) ([86fb294](86fb294)) * **Logo:** allow color override ([#1263](#1263)) ([4d16939](4d16939)) * **vanilla-extract:** remove sprinkles usages from TS files ([#1257](#1257)) ([b0d6040](b0d6040))
|
🎉 This PR is included in version 16.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB-2067
Example:
https://mistica-1i2esjses-flows-projects-65bb050e.vercel.app/playroom#?code=N4Igxg9gJgpiBcIA8AVGAbGAzCA7AlmAIYAyEA5hAAQAuAngA4wC8AOiPgLZGX1PtVI6CACc2IAEboiYANYCAzvgBeLYAA4ADAF8qAegB8rXCAA0IGgAsYnGAoQBtEACFpAVxABdcwHd8UK3t4BwBmADZNT20gA