-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Storybook): fix theme default values for stories opened in a new tab #1261
Conversation
Size stats
|
Accessibility report ℹ️ You can run this locally by executing |
@@ -63,16 +63,14 @@ const getTheme = ( | |||
selectedPlatform?: Platform, | |||
selectedColorScheme?: ColorScheme | |||
): ThemeConfig => { | |||
const skin = selectedSkin ?? MOVISTAR_SKIN; | |||
const platform = selectedPlatform ?? 'desktop'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When opening a story in a new tab without using any url params for the skin/platform/colorScheme, the platform was being set to desktop as fallback. This is wrong and it should have been fixed when we added the logic to avoid flashes between first and second render in storybook (#1048).
Deploy preview for mistica-web ready! ✅ Preview Built with commit 4da0450. |
Screenshot tests report ✔️ All passing |
🎉 This PR is included in version 16.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue: Link