Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BrandLoadingScreen): improve lottie animations #1235

Merged
merged 11 commits into from
Sep 13, 2024
Binary file not shown.
51 changes: 51 additions & 0 deletions .yarn/patches/lottie-react-npm-2.4.0-d4d95c55aa.patch
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using yarn patch to import the light version of lottie-web instead of the default one that the library uses. This is the main improvement

Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
diff --git a/build/index.d.ts b/build/index.d.ts
index d7bcde667d3db9510ee67e27ca4e6ecdd0641e14..9b28fd02c458e524107ed3f61cd945fecc0eeeed 100644
--- a/build/index.d.ts
+++ b/build/index.d.ts
@@ -1,6 +1,6 @@
/// <reference types="react" />
-import { AnimationDirection, AnimationSegment, AnimationItem, RendererType, AnimationConfigWithData, AnimationEventName } from 'lottie-web';
-export { default as LottiePlayer } from 'lottie-web';
+import { AnimationDirection, AnimationSegment, AnimationItem, RendererType, AnimationConfigWithData, AnimationEventName } from 'lottie-web/build/player/lottie_light';
+export { default as LottiePlayer } from 'lottie-web/build/player/lottie_light';
import * as react from 'react';
import react__default, { RefObject, MutableRefObject, AnimationEventHandler, ReactElement, CSSProperties } from 'react';

diff --git a/build/index.es.js b/build/index.es.js
index a2d9d48661a41bfb5c44df246eec19935d8a1162..1394d1116bd5a4b86ee2fdbbb9f096ad3824207f 100644
--- a/build/index.es.js
+++ b/build/index.es.js
@@ -1,5 +1,5 @@
-import lottie from 'lottie-web';
-export { default as LottiePlayer } from 'lottie-web';
+import lottie from 'lottie-web/build/player/lottie_light';
+export { default as LottiePlayer } from 'lottie-web/build/player/lottie_light';
import React, { useState, useRef, useEffect } from 'react';

function _iterableToArrayLimit(arr, i) {
diff --git a/build/index.js b/build/index.js
index ad6dbb0947b4a342383436808f2be3ab7161eaf3..3111e99f9e55e85786d971b931aedfaca419a617 100644
--- a/build/index.js
+++ b/build/index.js
@@ -2,7 +2,7 @@

Object.defineProperty(exports, '__esModule', { value: true });

-var lottie = require('lottie-web');
+var lottie = require('lottie-web/build/player/lottie_light');
var React = require('react');

function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { 'default': e }; }
diff --git a/build/index.umd.js b/build/index.umd.js
index 05a46ac14be5f01ef400c7dda874f4d4646d8f82..077e99122143581e0154794d8ca2419881e1bd84 100644
--- a/build/index.umd.js
+++ b/build/index.umd.js
@@ -1,6 +1,6 @@
(function (global, factory) {
- typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports, require('lottie-web'), require('react')) :
- typeof define === 'function' && define.amd ? define(['exports', 'lottie-web', 'react'], factory) :
+ typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports, require('lottie-web/build/player/lottie_light'), require('react')) :
+ typeof define === 'function' && define.amd ? define(['exports', 'lottie-web/build/player/lottie_light', 'react'], factory) :
(global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global["lottie-react"] = {}, global.Lottie, global.React));
})(this, (function (exports, lottie, React) { 'use strict';

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,8 @@
"react-dom": "18.2.0",
"@types/react": "^18.0.26",
"@types/react-dom": "^18.0.10",
"@testing-library/dom": "^8.19.1"
"@testing-library/dom": "^8.19.1",
"lottie-react@^2.4.0": "patch:lottie-react@npm%3A2.4.0#./.yarn/patches/lottie-react-npm-2.4.0-d4d95c55aa.patch"
},
"packageManager": "[email protected]",
"workspaces": [
Expand Down
618 changes: 285 additions & 333 deletions src/vivinho-loading-animation/in-lottie.json
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used https://www.lottiemizer.com/ to compress the JSON files

Large diffs are not rendered by default.

901 changes: 427 additions & 474 deletions src/vivinho-loading-animation/out-lottie.json

Large diffs are not rendered by default.

883 changes: 418 additions & 465 deletions src/vivinho-loading-animation/pulse-lottie.json

Large diffs are not rendered by default.

4,717 changes: 2,325 additions & 2,392 deletions src/vivinho-loading-animation/wave-lottie.json

Large diffs are not rendered by default.

14 changes: 13 additions & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -15544,7 +15544,7 @@ __metadata:
languageName: node
linkType: hard

"lottie-react@npm:^2.4.0":
"lottie-react@npm:2.4.0":
version: 2.4.0
resolution: "lottie-react@npm:2.4.0"
dependencies:
Expand All @@ -15556,6 +15556,18 @@ __metadata:
languageName: node
linkType: hard

"lottie-react@patch:lottie-react@npm%3A2.4.0#./.yarn/patches/lottie-react-npm-2.4.0-d4d95c55aa.patch::locator=%40telefonica%2Fmistica%40workspace%3A.":
version: 2.4.0
resolution: "lottie-react@patch:lottie-react@npm%3A2.4.0#./.yarn/patches/lottie-react-npm-2.4.0-d4d95c55aa.patch::version=2.4.0&hash=f4d8fa&locator=%40telefonica%2Fmistica%40workspace%3A."
dependencies:
lottie-web: ^5.10.2
peerDependencies:
react: ^16.8.0 || ^17.0.0 || ^18.0.0
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0
checksum: c04f89cb7be018773d60ff2615fae82e1d7e613d2737ebfd89453794483e30e845a436c74684a62cbeb58fd95c459366319f27a5b46d450a7f2ccfc8bc1e5cd0
languageName: node
linkType: hard

"lottie-web@npm:^5.10.2":
version: 5.12.2
resolution: "lottie-web@npm:5.12.2"
Expand Down
Loading