feat(Cards, Timer): added Timer's overMedia variant when used inside cards #1232
Conversation
There was a problem hiding this comment.
The text shadow is not very noticeable for non-boxed variant. @yceballost please confirm if the textShadow value is expected (it's written like this in specs)
There was a problem hiding this comment.
perhaps you could add another screenshot with a diferent (white-ish) background to make the shadow more noticeable
There was a problem hiding this comment.
should be the same text shadow as the rest of the text shadows in display media card and poster card
(in the case of the current cards in web is using 16px, but following specs should be 15px)
Line 1280 in ec7ed8b
https://www.figma.com/design/tKdPOfcUALzVIh5oizFbm7/%F0%9F%94%B8-Cards-Specs?node-id=8080-22155&t=v56aGyafkIMvhA15-4
the use of text shadows is primarily to ensure accessible contrast. If the background photo is dark, it's perfectly fine for the shadow to be less visible, as the background itself already provides the necessary contrast
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
There was a problem hiding this comment.
With this context, we can avoid creating a new variant in Mistica. It makes it easy to update the logic for components that require overMedia scenarios, without actually affecting the ones that don't have this variant.
For example, I've already updated all the cards and the Timer.
I've discussed with design team and, at least for now, we won't export this context outside of Mistica. This is because (ideally) we would like to create a new Variant for the ThemeVariant provider to handle this (and if we export this context now, it will be a breaking change when we remove it)
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 0fd12b9. |
marcoskolodny
changed the title
|
Closing, as we will replace this logic with the new theme variant |
Issue: Link