fix(Touchable): add maybe types to touchable props #1231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 526cbde. |
Winde
approved these changes
Sep 2, 2024
| @@ -62,3 +64,9 @@ import Chip from '../chip'; | |||
| <Chip to="/" onClose={() => {}}> | |||
| hello | |||
| </Chip>; | |||
|
|
|||
| const ChipMaybeOnPress = ({text, onPress}: {text: string; onPress?: PressHandler}): JSX.Element => ( | |||
| <Chip maybe onPress={onPress}> | |||
There was a problem hiding this comment.
It feels weird to see something like <Chip maybe/>. Perhaps we could consider something like maybeTouchable or maybeInteractive.
Also, this would require to add maybe in all the problematic scenarios. I'm not sure this really solves the issue. I think leaving it as it is won't be a big issue.
Let's discuss this a bit better in the next weekly
|
Discarded for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.tid.es/browse/WEB-1936