feat(skin): rename some design tokens #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 201cba7. |
2 tasks
|
Screenshot tests report ✔️ All passing |
yceballost
approved these changes
Aug 21, 2024
atabel
approved these changes
Aug 22, 2024
pladaria
approved these changes
Aug 22, 2024
|
I suggest to rename the pr title to "rename some internal design tokens" to be more clear about the impact of this change in release notes. I know that these token can be used in any place, but should not be a common use |
@yceballost I've modified the PR description with your suggestion (that message will be in the release notes) |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
tuentisre
pushed a commit
that referenced
this pull request
Sep 12, 2024
# [15.21.0](v15.20.1...v15.21.0) (2024-09-12) ### Features * **ButtonLink:** add default variant ([#1211](#1211)) ([047e058](047e058)) * **Callout, Cards, Dialog, EmptyState, EmptyStateCard, FeedbackScreen, Tabs:** remove icon prop and use only Icon/asset ([#1206](#1206)) ([afc4604](afc4604)) * **Feedback, FixedFooterLayout, Dialog, Accordion, Touchable, Header, IconButton, NavigationBar, OverscrollColor:** remove deprecated props ([#1205](#1205)) ([3808b4f](3808b4f)) * **Header, MainSectionHeader:** use "default" as component's default variant ([#1207](#1207)) ([8efe655](8efe655)) * **i18n:** refactor texts to improve bundle size ([#1228](#1228)) ([02e3ee1](02e3ee1)) * **Icons:** add new icons and rename others ([#1197](#1197)) ([0ff767c](0ff767c)) * **React:** require react18 and replace useAriaId with React.useId ([#1213](#1213)) ([672b873](672b873)) * **skin:** rename some design tokens ([#1203](#1203)) ([fcf15d0](fcf15d0)) * **Snackbar:** update snackbar duration logic ([#1208](#1208)) ([7df20eb](7df20eb)) * **ThemeVariant:** add media theme variant and update components in order to adapt to it ([#1236](#1236)) ([f14e82e](f14e82e)) * **Titles:** add new Title2, replace Title2 and Title3 with Title3 and Title4 respectively ([#1202](#1202)) ([7e405bb](7e405bb))
|
🎉 This PR is included in version 15.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
atabel
pushed a commit
that referenced
this pull request
Sep 13, 2024
BREAKING CHANGE: some mistica internal tokens are renamed
atabel
pushed a commit
that referenced
this pull request
Sep 13, 2024
# [15.21.0](v15.20.1...v15.21.0) (2024-09-12) ### Features * **ButtonLink:** add default variant ([#1211](#1211)) ([047e058](047e058)) * **Callout, Cards, Dialog, EmptyState, EmptyStateCard, FeedbackScreen, Tabs:** remove icon prop and use only Icon/asset ([#1206](#1206)) ([afc4604](afc4604)) * **Feedback, FixedFooterLayout, Dialog, Accordion, Touchable, Header, IconButton, NavigationBar, OverscrollColor:** remove deprecated props ([#1205](#1205)) ([3808b4f](3808b4f)) * **Header, MainSectionHeader:** use "default" as component's default variant ([#1207](#1207)) ([8efe655](8efe655)) * **i18n:** refactor texts to improve bundle size ([#1228](#1228)) ([02e3ee1](02e3ee1)) * **Icons:** add new icons and rename others ([#1197](#1197)) ([0ff767c](0ff767c)) * **React:** require react18 and replace useAriaId with React.useId ([#1213](#1213)) ([672b873](672b873)) * **skin:** rename some design tokens ([#1203](#1203)) ([fcf15d0](fcf15d0)) * **Snackbar:** update snackbar duration logic ([#1208](#1208)) ([7df20eb](7df20eb)) * **ThemeVariant:** add media theme variant and update components in order to adapt to it ([#1236](#1236)) ([f14e82e](f14e82e)) * **Titles:** add new Title2, replace Title2 and Title3 with Title3 and Title4 respectively ([#1202](#1202)) ([7e405bb](7e405bb))
tuentisre
pushed a commit
that referenced
this pull request
Sep 13, 2024
# [16.0.0](v15.20.1...v16.0.0) (2024-09-13) ### Features * **ButtonLink:** add default variant ([#1211](#1211)) ([97aa4ad](97aa4ad)) * **Callout, Cards, Dialog, EmptyState, EmptyStateCard, FeedbackScreen, Tabs:** remove icon prop and use only Icon/asset ([#1206](#1206)) ([eb06fa3](eb06fa3)) * **Feedback, FixedFooterLayout, Dialog, Accordion, Touchable, Header, IconButton, NavigationBar, OverscrollColor:** remove deprecated props ([#1205](#1205)) ([e1c84ec](e1c84ec)) * **Header, MainSectionHeader:** use "default" as component's default variant ([#1207](#1207)) ([29e0ef4](29e0ef4)) * **i18n:** refactor texts to improve bundle size ([#1228](#1228)) ([088a290](088a290)) * **Icons:** add new icons and rename others ([#1197](#1197)) ([4cfffa5](4cfffa5)) * **React:** require react18 and replace useAriaId with React.useId ([#1213](#1213)) ([b29f778](b29f778)) * **skin:** rename some design tokens ([#1203](#1203)) ([d0a1452](d0a1452)) * **Snackbar:** update snackbar duration logic ([#1208](#1208)) ([2ef5804](2ef5804)) * **ThemeVariant:** add media theme variant and update components in order to adapt to it ([#1236](#1236)) ([eada194](eada194)) * **Titles:** add new Title2, replace Title2 and Title3 with Title3 and Title4 respectively ([#1202](#1202)) ([bed8fdf](bed8fdf)) ### BREAKING CHANGES * **ThemeVariant:** a new theme variant has been added and it may require changes in any logic that depends on variants * **ButtonLink:** ButtonLink won't be small as default anymore * **i18n:** texts from useTheme are now empty by default. If a mistica defined text is required, it should be imported from text-tokens and must be translated using the t function from useTheme * **Callout, Cards, Dialog, EmptyState, EmptyStateCard, FeedbackScreen, Tabs:** icon/Icon/asset props are renamed in several components * **skin:** some mistica internal tokens are renamed * **Snackbar:** snackbar duration prop type has changed * **React:** react17 is no longer supported by Mistica and useAriaId hook is removed * **Header, MainSectionHeader:** Header's variant changes from inverse to default if variant prop is not used * **Feedback, FixedFooterLayout, Dialog, Accordion, Touchable, Header, IconButton, NavigationBar, OverscrollColor:** deprecated props are removed in several components * **Titles:** renamed Title2 to Title3 and Title3 to Title4 * **Icons:** renamed some icons autentication-failure → authentication-failure autentication-success → authentication-success adn → dna hamburguer → hamburger garaje → garage millenials → millennials not-photo-camera → no-photo-camera not-conexion-file → no-conexion-file smiley-happy → face-happy smiley-sad → face-sad like → thumb-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: some mistica internal tokens are renamed
Renamed tokens: Telefonica/mistica-design#1869
Issue: Link