Skip to content

Commit

Permalink
fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
marcoskolodny committed Sep 10, 2024
1 parent 18b9a64 commit 66e8784
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions src/card.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import IconPlayFilled from './generated/mistica-icons/icon-play-filled';
import {combineRefs} from './utils/common';
import Spinner from './spinner';
import Video from './video';
import {ThemeVariant, useIsInverseOrOverMediaVariant, useThemeVariant} from './theme-variant-context';
import {ThemeVariant, useIsInverseVariant, useThemeVariant} from './theme-variant-context';
import classNames from 'classnames';
import Inline from './inline';
import {getPrefixedDataAttributes} from './utils/dom';
Expand Down Expand Up @@ -1261,7 +1261,7 @@ const DisplayCard = React.forwardRef<HTMLDivElement, GenericDisplayCardProps>(
actions = videoAction ? [videoAction] : [];
}

const isExternalInverse = useIsInverseOrOverMediaVariant();
const isExternalInverse = useIsInverseVariant();
const withGradient = hasImage || hasVideo;
const textShadow = withGradient ? '0 0 16px rgba(0,0,0,0.4)' : undefined;
const hasTopActions = actions?.length || onClose;
Expand Down Expand Up @@ -1543,7 +1543,7 @@ export const PosterCard = React.forwardRef<HTMLDivElement, PosterCardProps>(
actions = videoAction ? [videoAction] : [];
}

const isExternalInverse = useIsInverseOrOverMediaVariant();
const isExternalInverse = useIsInverseVariant();
const withGradient = hasImage || hasVideo;
const textShadow = withGradient ? '0 0 16px rgba(0,0,0,0.4)' : undefined;
const hasTopActions = actions?.length || onClose;
Expand Down
2 changes: 1 addition & 1 deletion src/cover-hero.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ const CoverHero = React.forwardRef<HTMLDivElement, CoverHeroProps>(
})}
>
{hasMedia ? <CoverHeroMedia {...mediaProps} /> : null}
<ResponsiveLayout variant={hasMedia ? 'inverse' : variant} backgroundColor="none">
<ResponsiveLayout variant={hasMedia ? 'overMedia' : variant}>
<Box paddingY={noPaddingY ? 0 : {desktop: 56, tablet: 56, mobile: 24}}>
<Stack space={24}>
{centered && !sideExtra ? (
Expand Down
4 changes: 2 additions & 2 deletions src/image.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import classnames from 'classnames';
import {SkeletonAnimation} from './skeletons';
import {AspectRatioContainer} from './utils/aspect-ratio-support';
import {getPrefixedDataAttributes} from './utils/dom';
import {useIsInverseOrOverMediaVariant} from './theme-variant-context';
import {useIsInverseVariant} from './theme-variant-context';
import {useAriaId, useTheme} from './hooks';
import {VIVO_SKIN, VIVO_NEW_SKIN} from './skins/constants';
import {sprinkles} from './sprinkles.css';
Expand Down Expand Up @@ -42,7 +42,7 @@ type ImageErrorProps = {

export const ImageError = React.forwardRef<HTMLDivElement, ImageErrorProps>(
({borderRadius, withIcon = true, border, className}, ref) => {
const isInverse = useIsInverseOrOverMediaVariant();
const isInverse = useIsInverseVariant();
const {skinName} = useTheme();
return (
<div
Expand Down
2 changes: 1 addition & 1 deletion src/responsive-layout.css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export const forcedMarginMobileContainer = style({

export const backgroundVariant = {
inverse: sprinkles({background: skinVars.colors.backgroundBrand}),
overMedia: sprinkles({background: skinVars.colors.backgroundBrand}),
overMedia: sprinkles({background: 'transparent'}),
alternative: sprinkles({background: skinVars.colors.backgroundAlternative}),
};

Expand Down

0 comments on commit 66e8784

Please sign in to comment.