Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS-10212 update mi movistar tokens #370

Merged
merged 8 commits into from
Jun 11, 2024
Merged

iOS-10212 update mi movistar tokens #370

merged 8 commits into from
Jun 11, 2024

Conversation

WanaldinoTelefonica
Copy link
Contributor

@WanaldinoTelefonica WanaldinoTelefonica commented Jun 3, 2024 •
edited
Loading

🎟️ Jira ticket

IOS-10212

🥅 What's the goal?

  • Update MiMovistar tokens

🚧 How do we do it?

  • make skin ref=production

🏑 AppCenter build

image

@WanaldinoTelefonica WanaldinoTelefonica self-assigned this Jun 3, 2024
@WanaldinoTelefonica WanaldinoTelefonica force-pushed the IOS-10212-Update-MiMovistar-tokens branch from 0a737d7 to 8e4b618 Compare June 3, 2024 11:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Screenshot tests report

✔️ All passing

@WanaldinoTelefonica WanaldinoTelefonica force-pushed the IOS-10212-Update-MiMovistar-tokens branch 2 times, most recently from 1d55264 to 2f357ff Compare June 4, 2024 08:24
@WanaldinoTelefonica
Copy link
Contributor Author

WanaldinoTelefonica commented Jun 4, 2024 •
edited by github-actions bot
Loading

Record screenshots on PR comment: succeeded ✅
https://github.com/Telefonica/mistica-ios/actions/runs/9363927801

@WanaldinoTelefonica WanaldinoTelefonica requested review from a team, yceballost, idenjoe and alejandroruizponce and removed request for a team June 4, 2024 08:45
@WanaldinoTelefonica WanaldinoTelefonica marked this pull request as ready for review June 4, 2024 08:46
@WanaldinoTelefonica
Copy link
Contributor Author

WanaldinoTelefonica commented Jun 5, 2024 •
edited by github-actions bot
Loading

Record screenshots on PR comment: succeeded ✅
https://github.com/Telefonica/mistica-ios/actions/runs/9380870926

@WanaldinoTelefonica
Copy link
Contributor Author

WanaldinoTelefonica commented Jun 5, 2024 •
edited by github-actions bot
Loading

Record screenshots on PR comment: succeeded ✅
https://github.com/Telefonica/mistica-ios/actions/runs/9382169683

@WanaldinoTelefonica WanaldinoTelefonica force-pushed the IOS-10212-Update-MiMovistar-tokens branch from f0455d8 to d5c1516 Compare June 5, 2024 11:08
@WanaldinoTelefonica
Copy link
Contributor Author

WanaldinoTelefonica commented Jun 5, 2024 •
edited by github-actions bot
Loading

Record screenshots on PR comment: succeeded ✅
https://github.com/Telefonica/mistica-ios/actions/runs/9383209821

@WanaldinoTelefonica
Copy link
Contributor Author

WanaldinoTelefonica commented Jun 6, 2024 •
edited by github-actions bot
Loading

Record screenshots on PR comment: succeeded ✅
https://github.com/Telefonica/mistica-ios/actions/runs/9398396774

yceballost
yceballost requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@yceballost yceballost left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi guys!!

We need to make a little change in input fields (and select) to use textActivated instead of controlActivated token

This is to ensure accessibility in this type of texts

mistica-ios/Sources/Mistica/Components/InputField/InputField.swift

Line 917 in 3bb09ac

textInputView.tintColor = .controlActivated

This is our ticket in the design side, sorry, I forgot to create ticket of this to you :(
Telefonica/mistica-design#1733

@WanaldinoTelefonica
Copy link
Contributor Author

WanaldinoTelefonica commented Jun 10, 2024 •
edited by github-actions bot
Loading

Record screenshots on PR comment: succeeded ✅
https://github.com/Telefonica/mistica-ios/actions/runs/9446292707

@WanaldinoTelefonica
Copy link
Contributor Author

Hi guys!!

We need to make a little change in input fields (and select) to use textActivated instead of controlActivated token

This is to ensure accessibility in this type of texts

mistica-ios/Sources/Mistica/Components/InputField/InputField.swift

Line 917 in 3bb09ac

textInputView.tintColor = .controlActivated

This is our ticket in the design side, sorry, I forgot to create ticket of this to you :( Telefonica/mistica-design#1733

Hi @yceballost can you check it again?

@yceballost
Copy link
Contributor

Hi guys!!
We need to make a little change in input fields (and select) to use textActivated instead of controlActivated token
This is to ensure accessibility in this type of texts

mistica-ios/Sources/Mistica/Components/InputField/InputField.swift

Line 917 in 3bb09ac

textInputView.tintColor = .controlActivated

This is our ticket in the design side, sorry, I forgot to create ticket of this to you :( Telefonica/mistica-design#1733

Hi @yceballost can you check it again?

I can't see screenshot with this state to confirm! but I will trust 😄

@WanaldinoTelefonica WanaldinoTelefonica merged commit c305146 into main Jun 11, 2024
2 checks passed
@WanaldinoTelefonica WanaldinoTelefonica deleted the IOS-10212-Update-MiMovistar-tokens branch June 11, 2024 10:29
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 30.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idenjoe idenjoe idenjoe approved these changes

@yceballost yceballost yceballost approved these changes

@alejandroruizponce alejandroruizponce alejandroruizponce approved these changes

Assignees

@WanaldinoTelefonica WanaldinoTelefonica

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WanaldinoTelefonica @yceballost @tuentisre @idenjoe @alejandroruizponce