Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode tinted for o2-new #1751

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Dark mode tinted for o2-new #1751

merged 4 commits into from
Apr 30, 2024

Conversation

yceballost
Copy link
Collaborator

@yceballost yceballost commented Apr 25, 2024 •
edited by aweell
Loading

@yceballost yceballost changed the title Dark mode tinte for o2-new Dark mode tinted for o2-new Apr 25, 2024
yceballost
yceballost commented Apr 25, 2024
View reviewed changes
tokens/schema/skin-schema.json
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed darkModeBeyondBlueDark because is not used in constants

@HectorSancho
Copy link

HectorSancho commented Apr 30, 2024 •
edited
Loading

  • El o2Red65 de la paleta debería ser #BF4444

@HectorSancho
Copy link

  • Cambiar textTagError a o2Red45 para tener todos los textos rojos con el mismo color

@yceballost yceballost merged commit f20ed0b into production Apr 30, 2024
7 checks passed
@yceballost yceballost deleted the o2-new-darkMode branch April 30, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aweell aweell aweell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yceballost @HectorSancho @aweell