Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split control tokens (Chips, input labels, textTabBar) #1733

Closed
15 of 17 tasks
yceballost opened this issue Apr 16, 2024 Discussed in #1695 · 1 comment · Fixed by #1756
Closed
15 of 17 tasks

Split control tokens (Chips, input labels, textTabBar) #1733

yceballost opened this issue Apr 16, 2024 Discussed in #1695 · 1 comment · Fixed by #1756

Comments

@yceballost
Copy link
Collaborator

yceballost commented Apr 16, 2024

Create new two tokens:

  • TextBrand
  • TextActivated

  • textActivated will replace → textAppBarSelected (Icon is controlActivated, text is textActivated)
  • textActivated will replace usage of controlActivated in input labels and chip label
  • textBrand new token to use in Avatar elements (w/ initials)
  • textBrand new token to use in StackingGroup elements (+2)

Tasks

Discussed in #1695

Originally posted by HectorSancho March 8, 2024

Goal

Detach the control and activated control tokens and create two new tokens to better control the style in components such as chips and text fields.

Tokens proposal:

  • textActivated
  • borderActivated

Context

In the current definition we do not have much control over the color of these tokens, as they have dependencies with other components. It especially impacts on dark modes

Impact

Improve color definition in dark modes and be able to detach color styles from chips and other components of control tokens

Discussion Questions

is it necessary?

Additional considerations

No response

Do you have a visual proposal?

No response

@yceballost yceballost added this to the Q2'24 Projects milestone Apr 16, 2024
@yceballost yceballost changed the title Create chips tokens Split control tokens (Chips, input labels, textTabBar) Apr 25, 2024
@yceballost yceballost modified the milestones: Q2'24 Projects, 13.3.0 Apr 29, 2024
@aweell aweell self-assigned this May 3, 2024
@aweell aweell linked a pull request May 6, 2024 that will close this issue
@aweell
Copy link
Collaborator

aweell commented May 9, 2024

In inputs I also changed the definition of the label text when the field has error to textError and the helperText when is over inverse to textErrorInverse

Update: Telefonica/mistica-web#1125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment