Feat/topo map enhancements #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, schema validator panics because sync func is called within async context. Temporary W/A to at least overcome issue at least temporarily, up untill refactoring enforced. Also add RUST_BACKTRACE=1 to the run_cgw to enable tracing by default (if launched through helper script). Signed-off-by: Oleksandr Mazur <[email protected]>
| topo_map.process_state_message(&device_type, evt).await; | ||
| topo_map.debug_dump_map().await; | ||
|
|
||
| // TODO: remove this Arc clone: |
There was a problem hiding this comment.
Is this comment still relevant or should be removed?
There was a problem hiding this comment.
Not really. it states that #306 should be removed, and some other way of accessing NB API should be made further on;
Currently, a copy of Arc is being passed around and copied, and we potentially have to come up with a new approach;
| .process_device_topology_event(&device_type, evt) | ||
| .await; | ||
| topo_map.debug_dump_map().await; | ||
| // TODO: remove this Arc clone: |
Current approach aims to fight for best performance we can get
from topo map by utilizing the following key concepts:
- Event notification (notify NB about topo change) is handled
by async task;
- Events received from devices are pushed into queue for processing;
These events then processed asynchronously, without blocking the
underlying connections, to prevent websocket connections from
staggerring completely, and also to serialize the processing
of connections in a semi-synchronous manner
(events pushed asynchronously, but the processing of them
boils down to one-by-one FIFO-mannered processing synchronously)
Also added extended support for RT events: RT events now also generate
join/leave/migrate events to the NB services, so they can act
accordingly.
Current implementation also adds barebone support essentials
for graph-like presentation of topology, but doesn't implement
the graph generation itself (e.g. data is being collected / stored
in a way, in which future impl could just simply use it and focus
on the graph-generation algorith itself, rather then implementing
code that gathers data / tweaks parsers etc; Graph gen was postponed
due to lower priority).
Signed-off-by: Oleksandr Mazur <[email protected]>
Co-developed-by: Sviatoslav Boichuk <[email protected]>
Signed-off-by: Sviatoslav Boichuk <[email protected]>
Cahb
force-pushed
the
feat/topo_map_enhancements
branch
from
c28a462
to
3bc34fc
Compare
SviatoslavBoichuk
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.