Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customized branch for use in LYNX (leave PR open, need not merge) #455

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Dec 6, 2022

Some changes are as follows:

  • a different format for response generation
  • comment out console prints
  • another json function for elements, to view metrics as the signal is propagated.

This is an opinionated customization specifically for LYNX and will probably include more changes as we need them. Any suggestions are welcome.

@jktjkt
Copy link
Collaborator

jktjkt commented Jan 18, 2023

Hi @mohammadsaadraza , awesome to see how you're using GNPy. When you're ready to push small, incremental changes to GNPy, please consider using Gerrit since that's where the development is taking place.

Since this looks like a long-term work-in-progress draft PR, I wonder if there's a technical reason for leaving it open. Does it make your workflow easier in some way? If not, I would prefer to close the PR since it doesn't appear that we (GNPy maintainers) can do much at this point.

@ghost
Copy link
Author

ghost commented Jan 19, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants