LDAP and BILL syncing issues #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with regards to a new separate check of LDAP account existance.
…plifying the task in other places.
…m other 'BILL errors'. This also resolces issue #187.
backjonas
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where a Member could have a username that referred to a non-existent LDAP account, making it impossible to 1) change email, 2) delete/modify the LDAP-account and 3) create BILL account. Added a separate check to see if an LDAP-account exists, and making it possible to just remove the username from the Member if the LDAP-account does not exist. This resolves issue #186.
Fixed the same bug on the BILL side, where a Member could have a BILL account number referring to a non-existent BILL-code. This resolves issue #187.