Implement Travis CI for testing with Docker #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation pulls the Docker image, runs the built-in test, and compares the summarized output to what is expected. The .travis.yml travis_wait and sleep hack is necessary because travis otherwise fails during assembly due to the lack of output for over 10min while constructing the target De Bruijn graph within the [build] command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mstubb ,
This address #15 by pulling the Docker image, running the built-in test, and comparing the
summarized output to what is expected. The
travis_wait 20 sleep 1200 &hack in.travis.ymlis necessary because travis otherwise fails during assembly due to the lack of console output for over 10min while constructing the target De Bruijn graph within theKallisto [build]command.Right now the build is failing due to the fact that dictionaries are unordered, but this should be fixed once the Docker image is updated with the two included
sortedadditions tobracerlib/tasks.py.If you like this, going forward it probably makes sense that you open a (free for open source) travis-ci account and link to this repository so builds automatically occur after a push or pull request. Something similar could be implemented for tracer, and also include tracer's unit tests.
Best,
Derek