Skip to content
This repository has been archived by the owner on May 13, 2021. It is now read-only.

Update to fabric 1.16.4 and fix config screen crash #306

Open
wants to merge 1 commit into
base: 1.16_fabric
Choose a base branch
from

Conversation

deirn
Copy link

@deirn deirn commented Nov 18, 2020

Fixes #305 by using LiteralText.EMPTY instead of null when creating ButtonWidget

I also updated it to loom 0.5 since it failed to build on 0.4 ¯\_(ツ)_/¯
3:15:31 PM: Executing task 'build'...


> Configure project :
Fabric Loom: 0.4.33 Build(jenkins #33)
:setting up loom dependencies
:setting up mappings (yarn 1.16.4+build.7)
Configuring compiler arguments for Java

> Task :compileJava
2020-11-18 15:15:39,408 Execution worker for ':' WARN Unable to instantiate org.fusesource.jansi.WindowsAnsiOutputStream
Note: SpongePowered MIXIN Annotation Processor Version=0.8.2
Note: ObfuscationServiceFabric supports type: "official:intermediary"
Note: ObfuscationServiceFabric supports type: "official:named"
Note: ObfuscationServiceFabric supports type: "intermediary:official"
Note: ObfuscationServiceFabric supports type: "intermediary:named"
Note: ObfuscationServiceFabric supports type: "named:official"
Note: ObfuscationServiceFabric supports type: "named:intermediary"
Note: ObfuscationServiceMCP supports type: "searge"
Note: ObfuscationServiceMCP supports type: "notch"
Note: Loading named:intermediary mappings from C:\Users\bai\.gradle\caches\fabric-loom\mappings\yarn-1.16.4+build.7-v2.tiny
Note: Writing refmap to E:\deirn\idea\HWYLA\build\classes\java\main\hwyla-refmap.json
Note: Writing refmap to E:\deirn\idea\HWYLA\build\classes\java\main\hwyla-refmap.json
Note: Writing named:intermediary output TinyMappings to E:\deirn\idea\HWYLA\build\loom-cache\mixin-map-1.16.4-1.16.4+build.7-v2.tiny
Note: Writing refmap to E:\deirn\idea\HWYLA\build\classes\java\main\hwyla-refmap.json
Note: Writing refmap to E:\deirn\idea\HWYLA\build\classes\java\main\hwyla-refmap.json
Note: Writing named:intermediary output TinyMappings to E:\deirn\idea\HWYLA\build\loom-cache\mixin-map-1.16.4-1.16.4+build.7-v2.tiny
E:\deirn\idea\HWYLA\src\main\java\mcp\mobius\waila\gui\config\OptionsListWidget.java:21: error: cannot access Nullable
public class OptionsListWidget extends ElementListWidget<OptionsListWidget.Entry> {
     ^
class file for org.jetbrains.annotations.Nullable not found
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

> Task :compileJava FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.4.1/userguide/command_line_interface.html#sec:command_line_warnings
1 actionable task: 1 executed

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 9s
3:15:41 PM: Task execution finished 'build'.

everything else is just works

@deirn deirn changed the title Update to 1.16.4 and fix config screen crash Update to fabric 1.16.4 and fix config screen crash Nov 18, 2020
@hihey560
Copy link

hihey560 commented Nov 21, 2020

I'm new to using GitHub, but how could I take your edits and apply them to the source code, then compile into a jar for me to use as a mod?

@deirn
Copy link
Author

deirn commented Nov 22, 2020

you can clone my fork or download the source zip https://github.com/badasintended/hwyla/archive/fabric-1.16.4.zip and run
./gradlew build on *nix or gradlew.bat build on windows. the jar will be in build/libs

i also released the binaries in https://github.com/badasintended/hwyla/releases/tag/pr-306

@Guanran928
Copy link

uh is there any way to fix this issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants