Make <LitStr as FromMeta>::from_string no longer return an error #314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FromMeta
implementation forsyn::LitStr
is now more complete fixing difficult to debug macropanics that would occur when the type was used to build the macro.
Without this commit I would get the following panics:
for my derive macro built using darling. One of the structs nested on the one that had derived
darling::FromDeriveInput
usedsyn::LitStr
type as its field. With this commit which actually adds onlyfrom_string
function, lines 579-581, (the rest is copy-paste from thefrom_meta_lit!
macro) the panic is gone.I am not familiar with
syn
so I guess there might be a smarter way of creating LitStr from a &str but this works for me perfectly fine.