Update wdb stop signal hack #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
added
automerge
Previous hack made it quick to stop the `wdb.server.py` process, which doesn't react properly to `SIGTERM` as explained in Kozea/wdb#136. However, if this process was still alive, when powering off the computer it took forever to kill it. Thus, using this alternative hack is better, because it uses docker's built-in `tini` to reap child processes. It is still fast, but it also helps the host's process reaper to work reliably. BTW I update MQT submodule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous hack made it quick to stop the
wdb.server.pyprocess, which doesn't react properly toSIGTERMas explained in Kozea/wdb#136.However, if this process was still alive, when powering off the computer it took forever to kill it. Thus, using this alternative hack is better, because it uses docker's built-in
tinito reap child processes. It is still fast, but it also helps the host's process reaper to work reliably.BTW I update MQT submodule.