Xings Project weather a11y - this is a hand-in for the Accessibility week. #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Nice job with the accessibility work! The aria label on the search icon makes total sense, and good that you have a label for the search input as well. Your usage of semantic elements also ensures accessibility. The lighthouse report came back good and your contrast seems sufficient.
Just a note about tabindex, it’s usually used to make interactive elements navigable with keyboard. Since the forecast data is not clickable in anyway, I don’t think you need tabindex for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://xingsweatherapp.netlify.app/