-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xings Project weather a11y - this is a hand-in for the Accessibility week. #432
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job with the accessibility work! The aria label on the search icon makes total sense, and good that you have a label for the search input as well. Your usage of semantic elements also ensures accessibility. The lighthouse report came back good and your contrast seems sufficient.
Just a note about tabindex, it’s usually used to make interactive elements navigable with keyboard. Since the forecast data is not clickable in anyway, I don’t think you need tabindex for that.
https://xingsweatherapp.netlify.app/