Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jonas Hellström: Project news site. #529

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Jonash189
Copy link

@Jonash189 Jonash189 commented Aug 25, 2024

My news/magazine site project:

https://bespoke-rolypoly-62e0aa.netlify.app/

@Jonash189 Jonash189 changed the title Project news site Jonas Hellström: Project news site. Aug 25, 2024
@JennieDalgren JennieDalgren self-assigned this Aug 28, 2024
Copy link
Collaborator

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this project!

CSS Grid & Flexbox:

The use of CSS Grid in the articles section is well-executed. It provides a clean and structured layout.
To try: For the future, experiment with using grid-template-columns: repeat(auto-fit, minmax()) in your grid to enhance responsiveness, particularly for varying screen sizes.

CSS Structure:

Your CSS is well-organized and easy to read. It’s clear you’ve put thought into the structure and naming conventions.
Tip: Adding comments in more complex areas of your CSS, such as where specific breakpoints are defined, can make your code easier to maintain and understand.

Fantastic work overall! The site looks polished, and you’ve clearly put effort into making it responsive and user-friendly. Keep refining those details, and you’re on a great path! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants