Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estefanny's news website assignment #526

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

FannyEste
Copy link

No description provided.

@JennieDalgren JennieDalgren self-assigned this Aug 27, 2024
Copy link
Collaborator

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this project! It meets the requirement.

Grid and Flexbox Usage:

The grid layout works perfectly for the articles section. Nice work!
To explore: Try using grid-template-columns: repeat(auto-fit, minmax()) for greater flexibility on smaller screens and see what that gives you.

Responsive Design:

Your media queries work well across devices, but the layout on mobile can feel a bit cramped. Increasing padding or adjusting font sizes may improve readability.
Also, try to add width: 100%; to the body as it looks like how have some unintentional white space to the right, on smaller screens.

Image Optimization:

We havent talked about this, but this is something for you to explore.
Some of the images are quite large. Consider optimizing images to improve loading times and performance, especially for mobile devices.

Code Structure:

The code is clear and organized. You might benefit from adding comments to your CSS, especially in complex sections like media queries.

Great job! You're making fantastic progress. Keep it up! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants