Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W9-movie-site #64

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

W9-movie-site #64

wants to merge 13 commits into from

Conversation

jingh999
Copy link

@jingh999 jingh999 commented Apr 7, 2024

@HIPPIEKICK
Copy link
Contributor

HIPPIEKICK commented Apr 8, 2024

Feel free to open a question on SO if you need any help deploying 😇

@jingh999
Copy link
Author

jingh999 commented Apr 8, 2024

Feel free to open a question on SO if you need any help deploying 😇

Hi! I figured it out. Now the link is updated.

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your project is well structured, just some minor things regarding spacing, naming and consistency to think about going forward. What you need to fix for this project though is the responsiveness, so have a look at how your app behaves in 320px width. Apart from that - good job!

src/pages/ShowMovie.css Outdated Show resolved Hide resolved
src/App.jsx Outdated Show resolved Hide resolved
src/components/Cover.css Outdated Show resolved Hide resolved
src/components/Cover.jsx Outdated Show resolved Hide resolved
src/components/Cover.jsx Outdated Show resolved Hide resolved
src/components/Cover.jsx Outdated Show resolved Hide resolved
src/components/details/Background.jsx Outdated Show resolved Hide resolved
src/components/details/Description.jsx Outdated Show resolved Hide resolved
src/pages/MovieList.jsx Outdated Show resolved Hide resolved
@HIPPIEKICK
Copy link
Contributor

The "back button" doesn't work on smaller devices 👀 Apart from that, it looks good!

@jingh999
Copy link
Author

jingh999 commented May 4, 2024

is the respon

fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants