Movies by Erika and Alex #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexandra Franzén <[email protected]>
Added image links and id to each movie
Fetch URL with id property from MovieDetail component
added some styling to movie page
Added css to MovieDetail component
Co-authored-by: Alexandra Franzén <[email protected]> Co-authored-by: Pernilla Sterner <[email protected]>
HIPPIEKICK
approved these changes
Apr 10, 2024
Comment on lines
+38
to
+45
| .rating { | ||
| color: black; | ||
| font-weight: bolder; | ||
| background-color: rgb(250, 235, 215, 0.2); | ||
| max-width: fit-content; | ||
| max-height: 22px; | ||
| border-radius: 2px; | ||
| } |
There was a problem hiding this comment.
Consider increasing the contrast here, it's not so easy to see the text on some backgrounds:
There was a problem hiding this comment.
Actually I think it could be good to double check contrasts of all texts:
Comment on lines
+7
to
+17
| return ( | ||
| <BrowserRouter> | ||
| <main> | ||
| <Routes> | ||
| <Route path="/" element={<MoviesList />} /> | ||
| <Route path="/movies/:id" element={<MovieDetail />} /> | ||
| </Routes> | ||
| </main> | ||
| </BrowserRouter> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Nice and clean App structure 👍
Comment on lines
+1
to
+2
| import { useState,useEffect } from "react" | ||
| import { Link } from "react-router-dom"; |
There was a problem hiding this comment.
Remember to be consistent throughout your whole project regarding semicolons
| <Link to={`movies/${movie.id}`}> | ||
| <img | ||
| src={`https://image.tmdb.org/t/p/w342${movie.poster_path}`} | ||
| alt={`Poster of ${movie.title}`} |
There was a problem hiding this comment.
Good that you remembered the alt tags!
| @@ -2,7 +2,7 @@ | |||
| <html lang="en"> | |||
| <head> | |||
| <meta charset="UTF-8" /> | |||
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> | |||
| <link rel="icon" type="image/ico" href="/favicon.ico" /> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://classy-madeleine-9259db.netlify.app/
Collaborators
Add your collaborators here. Write their GitHub usernames in square brackets. If there's more than one, separate them with a comma, like this:
[Xikitita]