-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Movies by Erika and Alex #54
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Alexandra Franzén <[email protected]>
Added image links and id to each movie
Fetch URL with id property from MovieDetail component
added some styling to movie page
Added css to MovieDetail component
Co-authored-by: Alexandra Franzén <[email protected]> Co-authored-by: Pernilla Sterner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your project is nice and clean, and it looks good too. It's just the contrast that I think could benefit from another take.
.rating { | ||
color: black; | ||
font-weight: bolder; | ||
background-color: rgb(250, 235, 215, 0.2); | ||
max-width: fit-content; | ||
max-height: 22px; | ||
border-radius: 2px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return ( | ||
<BrowserRouter> | ||
<main> | ||
<Routes> | ||
<Route path="/" element={<MoviesList />} /> | ||
<Route path="/movies/:id" element={<MovieDetail />} /> | ||
</Routes> | ||
</main> | ||
</BrowserRouter> | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clean App structure 👍
import { useState,useEffect } from "react" | ||
import { Link } from "react-router-dom"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to be consistent throughout your whole project regarding semicolons
<Link to={`movies/${movie.id}`}> | ||
<img | ||
src={`https://image.tmdb.org/t/p/w342${movie.poster_path}`} | ||
alt={`Poster of ${movie.title}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that you remembered the alt tags!
@@ -2,7 +2,7 @@ | |||
<html lang="en"> | |||
<head> | |||
<meta charset="UTF-8" /> | |||
<link rel="icon" type="image/svg+xml" href="/vite.svg" /> | |||
<link rel="icon" type="image/ico" href="/favicon.ico" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍿 ⭐
Netlify link
https://classy-madeleine-9259db.netlify.app/
Collaborators
Add your collaborators here. Write their GitHub usernames in square brackets. If there's more than one, separate them with a comma, like this:
[Xikitita]