-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Movie Site Project - W9 #49
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with the project! Some minor clean up could be needed, but overall I think it looks good ⭐
export const App = () => { | ||
return <div>Find me in src/app.jsx!</div>; | ||
return ( | ||
<> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need this fragment? 👀
import "../components/movielist.css"; | ||
|
||
const MovieList = () => { | ||
const [movieList, setMovieList] = useState([]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonky indentation makes the code harder to read and the fact that it's not consistent (the App.jsx looked good) makes the code look less clean
<div className="movie-page"> | ||
<div className="menu"> | ||
|
||
<button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea! Would be nice with cursor: pointer; on all interactive elements
|
||
export default function SingleMovie() { | ||
const { id } = useParams(); | ||
console.log(id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove console.logs in production
width="32" | ||
height="32" | ||
src="/back-arrow.png" | ||
alt="backwards-arrow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to always keep the CSS to the CSS files
https://popularmovies-bmm.netlify.app/