Project Happy Thoughts by Emma Engvall #445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeandjazz
reviewed
Mar 28, 2023
| setNewThought(event.target.value) | ||
| } | ||
|
|
||
| //Posting a new thought to the API |
| const characterWarning = () => { | ||
| if (newThought.length > 140 ) { | ||
| return ( | ||
| <p className="character-warning">You are trying to send too much love.</p>) |
There was a problem hiding this comment.
Haha too much love is apparently a thing-in this app, atleast
codeandjazz
reviewed
Mar 28, 2023
There was a problem hiding this comment.
Okay I accidentally submitted my review too early, nevermind the mess.
I loved seeing how closely you were able to follow the design and how incredibly functional your app is. It's doing everything it needs to do. One thing you could improve upon maybe is the responsiveness in mobile. At 320px, the thought form is being cropped quite drastically!
Your code is so clean, easy to read and nice to look at. Keep up the amazing work and I'm sure you will be building even more breathtakingly beautiful apps after the BC <3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.