Happy thoughts Josefin R #438
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannebrob
reviewed
Mar 31, 2023
|
|
||
| useEffect(() => { | ||
| updateThoughtsList(); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
Is there a reason why you didn't use eslint-disable in the whole file? Makes it easier (in my own opinion) to remove if necessary in the top level of the file.
| return ( | ||
| <div className="inputForm"> | ||
| <form onSubmit={handleFormSubmit}> | ||
| <h3>What's making you happy right now?</h3> |
There was a problem hiding this comment.
&apos
Nice use off Predefined Character Entities (had to look up that name😅 )
code/src/components/SingleThought.js
Outdated
Comment on lines
5
to
15
| const SingleThought = ({ thought, onHeartClick }) => { | ||
| const date = new Date(thought.createdAt); | ||
| const timeDiff = Math.round((new Date() - date) / (1000 * 60)); | ||
| if (timeDiff < 1) { | ||
| timeStamp = 'just now'; | ||
| } else if (timeDiff < 90) { | ||
| timeStamp = `${timeDiff} min ago`; | ||
| } else { | ||
| const hoursDiff = Math.round(timeDiff / 60); | ||
| timeStamp = `${hoursDiff} hour${hoursDiff > 1 ? 's' : ''} ago`; | ||
| } |
There was a problem hiding this comment.
A very nice structured function; Its easy to understand.
code/src/components/InputForm.js
Outdated
| onChange={handleInputChange} | ||
| maxLength="140" /> | ||
| <div id="counter">140/{charCount}</div> | ||
| <button type="submit"><span id="heart"> Send Happy Thought </span></button> |
There was a problem hiding this comment.
You might want to add a feature that disables the send button if a value (<= 5) is entered in the text box;, to prevent a error message from the API, that gets rendered out in the DataList component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.