Martin - Happy Thoughts API #476
Conversation
| // Get all the thoughts | ||
| const thoughts = await Thought.find().sort( | ||
| { createdAt: "desc" }).limit(20).exec(); |
There was a problem hiding this comment.
I might be completely wrong here, but I just reacted because I did it differently. If there are errors thrown by "await Thought.find()", would they be handled? I'm thinking since it's outside of the try/catch?
There was a problem hiding this comment.
I'd also put it in the try block 👍
| res.status(201).json(thoughts); | ||
| } catch (err) { | ||
| res.status(400).json({ | ||
| message: "Could not retrieve the Happy Thoughts.", |
There was a problem hiding this comment.
Interesting, we used different status codes here 😄
In "try" I used 200 as I read it's a more general "OK" status for GET requests while 201 specifically means "created" when you have done a successful POST request.
In "catch" I used 500 which indicates server-side errors (such as database query error, ,which would likely be the case here).
But again, might be wrong here too! By no means I feel comfortable with these status codes, just find it interesting that we chose different ones :)
|
|
||
| app.post("/thoughts/", async (req, res) => { | ||
| // Create a thought in the database | ||
| const { message, heart } = req.body; |
There was a problem hiding this comment.
Not so sure why heart would be a property here? I think it would be enough with "message" since "hearts" will not be edited in this endpoint 😊
| const { thoughtId } = req.params; | ||
|
|
||
| try { | ||
| const thought = await Thought.findByIdAndUpdate(thoughtId, {$inc: {hearts: 1}}, {new: true, runValidators: true}); |
There was a problem hiding this comment.
This looks like a cool and smooth way to update by 1. Nice 🤩
There was a problem hiding this comment.
Agreed! Just missing a bit of formatting 😇
| maxlength: 140, | ||
| minlength: 5, |
There was a problem hiding this comment.
Why maxlength before minlength? My eeeeyes 😅
| hearts: { type: Number, default: 0 }, | ||
| createdAt: { type: Date, default: Date.now }, |
There was a problem hiding this comment.
Format these lines as you did with the message for better readability
| // Get all the thoughts | ||
| const thoughts = await Thought.find().sort( | ||
| { createdAt: "desc" }).limit(20).exec(); |
There was a problem hiding this comment.
I'd also put it in the try block 👍
| const newThought = await thought.save(); | ||
| res.status(201).json(newThought); |
| } | ||
| }); | ||
|
|
||
| app.post("/thoughts/", async (req, res) => { |
There was a problem hiding this comment.
Minor thing, but no need for the second /
| const { thoughtId } = req.params; | ||
|
|
||
| try { | ||
| const thought = await Thought.findByIdAndUpdate(thoughtId, {$inc: {hearts: 1}}, {new: true, runValidators: true}); |
There was a problem hiding this comment.
Agreed! Just missing a bit of formatting 😇
Netlify link
Back end: https://happy-thoughts-api-uu1o.onrender.com/
Front end: https://manyhappythoughts.netlify.app/