mc - guesswho #350
mc - guesswho #350
Conversation
| const selectQuestion = () => { | ||
| console.log(selectQuestion) |
There was a problem hiding this comment.
Hello Mirela,
Nice Work Mirela!
your code looks mostly fine, but there are a few minor issues and improvements that can be made:
In the selectQuestion function, you have a console.log statement with console.log(selectQuestion). You should log the actual values or the result of the function, like console.log(currentQuestion), to see the selected question.
| if (personToCheck === secret.name) { | ||
| winOrLoseText.innerHTML = `That's correct!!! You won! Congratulations!`; | ||
| } else { | ||
| personToConfirm !== secret.name; |
There was a problem hiding this comment.
In the checkMyGuess function, you have an unnecessary line: personToConfirm !== secret.name;. It doesn't serve any purpose and can be removed.
| const filterCharacters = (keep) => { | ||
| const { category, value } = currentQuestion | ||
| // Show the correct alert message for different categories | ||
| if (category === 'accessories') { | ||
| if (keep) { | ||
| alert( | ||
| `Yes, the person wears ${value}! Keep all people that wears ${value}` | ||
| `Yes, the person wears ${value}! Keep all people who wear ${value}` | ||
| ) | ||
| } else { | ||
| alert( | ||
| `No, the person doesn't wear ${value}! Remove all people that wears ${value}` | ||
| `No, the person doesn't wear ${value}! Remove all people who wear ${value}` | ||
| ) | ||
| } | ||
| } else if (category === 'other') { | ||
| // Similar to the one above | ||
| } else { | ||
| if (keep) { | ||
| // alert popup that says something like: "Yes, the person has yellow hair! Keep all people with yellow hair" | ||
| alert(`Yes, the person wears ${value}! Keep all people who wear ${value}` | ||
| ) | ||
| } else { | ||
| alert( | ||
| `No, the person doesn´t wear ${value}! Remove all people who wear ${value}` | ||
| ) | ||
| } | ||
| } else if (category === 'hair') { |
There was a problem hiding this comment.
the readability of your filterCharacters function can be improved by avoiding the repetition of alert messages. You can create a single alert message and use template literals to make the code cleaner.
like the following :
const filterCharacters = (keep) => {
const { category, value } = currentQuestion;
let message;
if (category === 'accessories') {
message = person wears ${value};
} else if (category === 'other') {
message = person wears ${value};
} else if (category === 'hair') {
message = person has ${value} hair;
} else if (category === 'eyes') {
message = person has ${value} eyes;
}
if (keep) {
alert(Yes, the ${message}! Keep all people who ${message});
} else {
alert(No, the ${message}! Remove all people who ${message});
}
// FILTER BY CATEGORY TO KEEP/REMOVE BASED ON THE KEEP VARIABLE//
charactersInPlay = charactersInPlay.filter((person) => person[category].includes(value) === keep);
// Invoke a function to redraw the board with the remaining people.
generateBoard();
};
No description provided.