guess-who-elbines #346
Open
guess-who-elbines #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgalepisto
reviewed
Sep 13, 2023
| //it "Grabs" the board element and changing the inner html | ||
| board.innerHTML += | ||
| //use the information in the array (charactersInPlay) to shoe information about people. | ||
| //${person.name} the value of all the names in array (CHARACTERS) |
There was a problem hiding this comment.
The code is really well commented throughout so it's easy to keep up as a reader!
|
|
||
| currentQuestion = { | ||
| category: category, | ||
| // value: value | ||
| value: value, | ||
| textForAlert: textForAlert, //S |
There was a problem hiding this comment.
Just a suggestion, but I'm wondering if textForAlert could've been named in a more specific name to fit the context it's used for, maybe songType or chosenValue?
code/index.html
Outdated
|
|
||
| <img class="guess-who-icon" src="images/guess-who-bubble.png" alt="Guess Who" /> | ||
|
|
||
| <h1>Does the person have</h1> |
There was a problem hiding this comment.
This line could be changed to a title that refers to your theme :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.